Skip to content

Update analyzing the bundle size documentation #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update analyzing the bundle size documentation #6870

wants to merge 1 commit into from

Conversation

mistereechapman
Copy link

Found documentation to be incorrect for guiding developers on how to analyze the source map. It states that the path must be wrapped in a quotes which causes no files to be created
Bug #6715

Found documentation to be incorrect for guiding developers on how to analyze the source map. It states that the path must be wrapped in a quotes which causes no files to be created
Bug #6715
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bugzpodder
Copy link

Thanks for the PR.

I know this fixes it for windows users, but removing the quotes breaks for mac users. The only confirmed way of working for both set of users is to use npx.
The issue might be fixed in the next source-map-explorer release.
danvk/source-map-explorer#106

@mistereechapman
Copy link
Author

mistereechapman commented Apr 24, 2019

Thanks for the PR.

I know this fixes it for windows users, but removing the quotes breaks for mac users. The only confirmed way of working for both set of users is to use npx.
The issue might be fixed in the next source-map-explorer release.
danvk/source-map-explorer#106

Fair enough. Might just highlight that npx doesn't look to be working also.
I'll just note that on the original bug for others that might have followed the feedback and are getting no luck.

E:\Repo\dotNet\GMS\src\GiftCards\ClientApp\build\static\js (Working/ec/buildscripts2 -> origin)
λ npx source-map-explorer '*.js'
No file(s) found

E:\Repo\dotNet\GMS\src\GiftCards\ClientApp\build\static\js (Working/ec/buildscripts2 -> origin)
λ npx source-map-explorer *.js
[runtime~main.a8a9905a.js] Your source map only contains one source (../webpack/bootstrap)
This can happen if you use browserify+uglifyjs, for example, and don't set the --in-source-map flag to uglify.
See https://github.com/danvk/source-map-explorer/blob/master/README.md#generating-source-maps
[2.61ba3434.chunk.js] Unable to map 130/853167 bytes (0.02%)
[main.e8cf97e9.chunk.js] Unable to map 124/33011 bytes (0.38%)

@stale
Copy link

stale bot commented May 24, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 24, 2019
@stale
Copy link

stale bot commented May 29, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this May 29, 2019
@lock lock bot locked and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants