-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Update analyzing the bundle size documentation #6870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Found documentation to be incorrect for guiding developers on how to analyze the source map. It states that the path must be wrapped in a quotes which causes no files to be created Bug #6715
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks for the PR. I know this fixes it for windows users, but removing the quotes breaks for mac users. The only confirmed way of working for both set of users is to use npx. |
Fair enough. Might just highlight that npx doesn't look to be working also. E:\Repo\dotNet\GMS\src\GiftCards\ClientApp\build\static\js (Working/ec/buildscripts2 -> origin) E:\Repo\dotNet\GMS\src\GiftCards\ClientApp\build\static\js (Working/ec/buildscripts2 -> origin) |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
Found documentation to be incorrect for guiding developers on how to analyze the source map. It states that the path must be wrapped in a quotes which causes no files to be created
Bug #6715