Add no-bin-links option to create-react-app #7243
Conversation
proflayton
requested review from
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb,
petetnt and
Timer
as code owners
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
There was a problem hiding this comment.
I think this needs to be re-evaluated a bit since template support landed; I image --no-bin-links should probably be threaded through to the package installation in react-scripts for it to work like people expect. If you want to take a crack at it then feel free and I'll review! But I also understand if you want someone else to pick this up. Sorry it languished for so long!
| return new Promise((resolve, reject) => { | ||
| let command; | ||
| let args; | ||
| if (useYarn) { | ||
| command = 'yarnpkg'; | ||
| args = ['add', '--exact']; | ||
| if (!binLinks) { |
There was a problem hiding this comment.
Shouldn't this also be passed in if we're using npm?
This resolves this issue: #1394