Skip to content

Conversation

@Ryoga-exe
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Complete missing translations for Japanese locale.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 16, 2024
@netlify
Copy link

netlify bot commented Nov 16, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ef5eb36
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/67387925e0593a000838285f
😎 Deploy Preview https://deploy-preview-10688--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 61 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 55 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 61 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@slorber
Copy link
Collaborator

slorber commented Nov 18, 2024

Thanks 👍

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 18, 2024
@slorber slorber merged commit a53ddf6 into facebook:main Nov 18, 2024
34 of 36 checks passed
@Ryoga-exe Ryoga-exe deleted the theme-default-translations-ja branch December 15, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants