refactor: new @docusaurus/plugin-content-docs/client interface #6287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
|
✔️ [V2] 🔨 Explore the source changes: d30641f 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61d860a1ff7b0f000810fb84 😎 Browse the preview: https://deploy-preview-6287--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6287--docusaurus-2.netlify.app/ |
|
Size Change: +731 B (0%) Total Size: 675 kB
ℹ️ View Unchanged
|
slorber
commented
Jan 7, 2022
| '@theme/(.*)': '@docusaurus/theme-classic/src/theme/$1', | ||
| '@site/(.*)': 'website/$1', | ||
|
|
||
| // TODO why Jest can't figure node package entry points? |
11 tasks
feynmanliang
pushed a commit
to feynmanliang/beanmachine
that referenced
this pull request
Apr 5, 2022
…arch#1387) Summary: ### Motivation Fix vulnerability described in ai/nanoid#328 Note `docusaurus-plugin-internaldocs-fb` doesn't pin its hard docusaurus version dependency and facebook/docusaurus#6287 introduced a breaking change, so we need to pin docusaurus version to keep the build green. ### Changes proposed Upgrades pinned JS dep versions from running `yarn upgrade` Pull Request resolved: facebookresearch#1387 Test Plan: `yarn build` ### Types of changes - [x] Docs change / refactoring / dependency upgrade - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Checklist - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/facebookresearch/beanmachine/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. **Static Docs Preview: beanmachine** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D35151907/V5/beanmachine/)| |**Modified Pages**| Reviewed By: horizon-blue Differential Revision: D35151907 Pulled By: feynmanliang fbshipit-source-id: 051b702c83a482fb3d3dacbd8bb3ebe9a0109af3
facebook-github-bot
pushed a commit
to facebookresearch/beanmachine
that referenced
this pull request
Apr 5, 2022
Summary: ### Motivation Fix vulnerability described in ai/nanoid#328 Note `docusaurus-plugin-internaldocs-fb` doesn't pin its hard docusaurus version dependency and facebook/docusaurus#6287 introduced a breaking change, so we need to pin docusaurus version to keep the build green. ### Changes proposed Upgrades pinned JS dep versions from running `yarn upgrade` Pull Request resolved: #1387 Test Plan: `yarn build` ### Types of changes - [x] Docs change / refactoring / dependency upgrade - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ### Checklist - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **[CONTRIBUTING](https://github.com/facebookresearch/beanmachine/blob/main/CONTRIBUTING.md)** document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [x] The title of my pull request is a short description of the requested changes. **Static Docs Preview: beanmachine** |[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D35151907/V5/beanmachine/)| |**Modified Pages**| Reviewed By: horizon-blue Differential Revision: D35151907 Pulled By: feynmanliang fbshipit-source-id: b4274c7fc713fccddd1d1c64c9024138107a5716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Refactor the hacky
@theme/hooks/useDocshook into a proper@docusaurus/plugin-content-docs/clientinterfaceFirst cases where a plugin exposes its own client-side code
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
refactor: existing tests should pass