Skip to content

Fixed AnimationCoordinator.onRenderFrame by containsKey#2827

Open
pasha010 wants to merge 2 commits intofacebook:mainfrom
pasha010:fix/contains-animation-in-AnimationCoordinator
Open

Fixed AnimationCoordinator.onRenderFrame by containsKey#2827
pasha010 wants to merge 2 commits intofacebook:mainfrom
pasha010:fix/contains-animation-in-AnimationCoordinator

Conversation

@pasha010
Copy link

Motivation (required)

Class AnimationCoordinator contains bug in onRenderFrame.

Class ConcurrentHashMap method contains checks containsValue, not key.

Text from documentation:
Tests if some key maps into the specified value in this table.

https://developer.android.com/reference/java/util/concurrent/ConcurrentHashMap#contains(java.lang.Object)

@facebook-github-bot
Copy link
Contributor

Hi @pasha010!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@pasha010 pasha010 closed this Jul 7, 2025
@pasha010 pasha010 reopened this Dec 23, 2025
@pasha010
Copy link
Author

reopen

@meta-cla meta-cla bot added the CLA Signed label Dec 23, 2025
@meta-cla
Copy link

meta-cla bot commented Dec 23, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants