-
Notifications
You must be signed in to change notification settings - Fork 3k
Core dumped: Segmentation fault on PDO::__construct with SET NAMES init command #8111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think we are running into this problem: facebook/hhvm#8111 We don't solve that problem, but we avoid it by specifying utf8 in a different fashion. I also took the opportunity to use the "TFB-database" hostname instead of the DBHOST environment variable because it's simpler that way. Here are the steps I took in a local TFB environment that make me think we're running into the same issue as that GitHub issue: - Run toolset/run-tests.py --mode verify --test hvm, see that it fails all tests with error messages that look like the application server simply isn't there - Enable logging in PHP/hhvm/deploy/config.hdf (basically copy the "Log" section over from config-debug.hdf), run the test again - Look at the log file it spit out, PHP/hhvm/error.log, notice messages like this: Core dumped: Segmentation fault Stack trace in /tmp/stacktrace.28653.log - /tmp is cleared by the TFB toolset each run, so I comment out that part of benchmarker.py that clears /tmp - Run the test again, look at the stacktrace file in /tmp, notice a stack trace referring to our implementation code like this: #0 PDO->__construct() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:14] TechEmpower#1 Benchmark->setup_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:31] TechEmpower#2 Benchmark->bench_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:10] TechEmpower#3 main() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:13] - Google a bit, come across a GitHub issue talking about a similar problem when they used "SET NAMES" - Comment the part of PHP/hhvm/once.php.inc that uses SET NAMES, run test again and it worked, except for fortunes which failed because of character encoding problems - Google for a different way to specify utf8 in the PDO constructor, try it again, all tests pass locally
…3220) I think we are running into this problem: facebook/hhvm#8111 We don't solve that problem, but we avoid it by specifying utf8 in a different fashion. I also took the opportunity to use the "TFB-database" hostname instead of the DBHOST environment variable because it's simpler that way. Here are the steps I took in a local TFB environment that make me think we're running into the same issue as that GitHub issue: - Run toolset/run-tests.py --mode verify --test hvm, see that it fails all tests with error messages that look like the application server simply isn't there - Enable logging in PHP/hhvm/deploy/config.hdf (basically copy the "Log" section over from config-debug.hdf), run the test again - Look at the log file it spit out, PHP/hhvm/error.log, notice messages like this: Core dumped: Segmentation fault Stack trace in /tmp/stacktrace.28653.log - /tmp is cleared by the TFB toolset each run, so I comment out that part of benchmarker.py that clears /tmp - Run the test again, look at the stacktrace file in /tmp, notice a stack trace referring to our implementation code like this: #0 PDO->__construct() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:14] #1 Benchmark->setup_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:31] #2 Benchmark->bench_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:10] #3 main() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:13] - Google a bit, come across a GitHub issue talking about a similar problem when they used "SET NAMES" - Comment the part of PHP/hhvm/once.php.inc that uses SET NAMES, run test again and it worked, except for fortunes which failed because of character encoding problems - Google for a different way to specify utf8 in the PDO constructor, try it again, all tests pass locally
Similar issue. hhvm --version
Ubuntu 16.04.3, on Amazon c5.large server
|
@fredemmott any updates on this? hhvm is now completely useless. |
I'll follow up with our mysql team on https://github.com/facebook/mysql-5.6/pull/781/files Once that's reviewed, this and #8050 are one of the next few things I want to look at. |
@fredemmott when can we expect a release (specifically stable)? |
It should be this week; I'm hoping to also get a fix for #8061 and hh_client hangs on mac in, but I'll push this out by itself if those end up delaying this more than a day or two. |
…echEmpower#3220) I think we are running into this problem: facebook/hhvm#8111 We don't solve that problem, but we avoid it by specifying utf8 in a different fashion. I also took the opportunity to use the "TFB-database" hostname instead of the DBHOST environment variable because it's simpler that way. Here are the steps I took in a local TFB environment that make me think we're running into the same issue as that GitHub issue: - Run toolset/run-tests.py --mode verify --test hvm, see that it fails all tests with error messages that look like the application server simply isn't there - Enable logging in PHP/hhvm/deploy/config.hdf (basically copy the "Log" section over from config-debug.hdf), run the test again - Look at the log file it spit out, PHP/hhvm/error.log, notice messages like this: Core dumped: Segmentation fault Stack trace in /tmp/stacktrace.28653.log - /tmp is cleared by the TFB toolset each run, so I comment out that part of benchmarker.py that clears /tmp - Run the test again, look at the stacktrace file in /tmp, notice a stack trace referring to our implementation code like this: #0 PDO->__construct() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:14] #1 Benchmark->setup_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/once.php.inc:31] #2 Benchmark->bench_db() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:10] #3 main() called at [/home/techempower/FrameworkBenchmarks/frameworks/PHP/hhvm/db.php:13] - Google a bit, come across a GitHub issue talking about a similar problem when they used "SET NAMES" - Comment the part of PHP/hhvm/once.php.inc that uses SET NAMES, run test again and it worked, except for fortunes which failed because of character encoding problems - Google for a different way to specify utf8 in the PDO constructor, try it again, all tests pass locally
@fredemmott Thank you |
Uh oh!
There was an error while loading. Please reload this page.
Stack Trace:
stacktrace.28601.log
HHVM Version
3.24.0
installed from hhvm_3.24.0-1~trusty_amd64.deb package
Operating System and Version
Ubuntu 14.04.5 LTS (GNU/Linux 3.13.0-139-generic x86_64)
MySQL Version: 5.7.21-log MySQL Community Server (GPL)
Standalone code, or other way to reproduce the problem
Expected result
Connected PDO instance, or PDOException thrown
Actual result
HHVM crashes with a Seg Fault.
Notes:
If the PDO::MYSQL_ATTR_INIT_COMMAND is removed, the error does not occur.
Possibly related to #8050 since both involve setting the charset.
This was previously working on 3.18.5~trusty debian package. It currently works in php 5.6.
The text was updated successfully, but these errors were encountered: