fix: resolve #492 — Double semicolons in interface after insert#702
Conversation
Fixes facebook#492 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
Fixes facebook#492 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
Fixes facebook#492 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
Fixes facebook#492 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
|
|
@ed-thuando is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @ed-thuando! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
||
| // Configure printer with TypeScript support for proper handling | ||
| // of constructs like TSInterfaceDeclaration and TSPropertySignature | ||
| const printer = new Printer({ |
There was a problem hiding this comment.
This variable isn't used anywhere
| }); | ||
| }); | ||
|
|
||
| it('returns a Collection from a TypeScript interface declaration', function () { |
There was a problem hiding this comment.
What does this have to do with the issue in the PR title?
2 participants
Summary
fix: resolve #492 — Double semicolons in interface after insert
Problem
Severity:
High| File:src/core.jsExamine how the printer is configured in jscodeshift and how TypeScript printing is handled. This file likely contains the main printer setup.
Solution
Look for printer configuration, particularly for TypeScript constructs like TSInterfaceDeclaration and TSPropertySignature. Search for how semicolons are handled for TypeScript properties.
Changes
src/core.js(modified)parser/tsx.js(modified)src/collections/Node.js(modified)src/__tests__/core-test.js(modified)Testing
Generated by ContribAI v6.0.0