Skip to content

[lexical] Bug Fix: Resolve Firefox arrow key navigation issue in collapsible nodes (#8348) #8349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etrepum merged 3 commits into from
Apr 14, 2026
Merged

[lexical] Bug Fix: Resolve Firefox arrow key navigation issue in collapsible nodes (#8348) #8349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
380e51f
fix: resolve Firefox arrow key navigation bug in collapsible nodes (#…
MohmedIkram Apr 12, 2026
428c539
test: fix collapsible firefox arrow key
MohmedIkram Apr 14, 2026
895250c
Merge branch 'main' into fix-firefox-collapsible-8348
etrepum Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 77 additions & 2 deletions packages/lexical-playground/__tests__/e2e/Selection.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,10 @@ test.describe.parallel('Selection', () => {
await moveRight(page, 3);
await deleteForward(page);

const collapsibleTag = browserName === 'chromium' ? 'div' : 'details';
const collapsibleTag =
browserName === 'chromium' || browserName === 'firefox'
? 'div'
: 'details';
await assertHTML(
page,
html`
Expand Down Expand Up @@ -665,7 +668,10 @@ test.describe.parallel('Selection', () => {
await moveLeft(page, 'after'.length);
await deleteBackward(page);

const collapsibleTag = browserName === 'chromium' ? 'div' : 'details';
const collapsibleTag =
browserName === 'chromium' || browserName === 'firefox'
? 'div'
: 'details';
await assertHTML(
page,
html`
Expand Down Expand Up @@ -694,6 +700,75 @@ test.describe.parallel('Selection', () => {
);
});

test('Arrow keys navigate into/out of collapsible content in all browsers (#8348)', async ({
page,
isPlainText,
browserName,
}) => {
test.skip(isPlainText);
await focusEditor(page);

await page.keyboard.type('before');
await insertCollapsible(page);
await page.keyboard.type('title');
await moveRight(page, 2);
await page.keyboard.type('after');

await moveToEditorBeginning(page);
await moveDown(page, 1);
await moveDown(page, 1);

const collapsibleTag =
browserName === 'chromium' || browserName === 'firefox'
? 'div'
: 'details';

await assertHTML(
page,
html`
<p class="PlaygroundEditorTheme__paragraph" dir="auto">
<span data-lexical-text="true">before</span>
</p>
<${collapsibleTag} class="Collapsible__container" dir="auto" open="">
<summary class="Collapsible__title">
<p class="PlaygroundEditorTheme__paragraph">
<span data-lexical-text="true">title</span>
</p>
</summary>
<div class="Collapsible__content">
<p class="PlaygroundEditorTheme__paragraph"><br /></p>
</div>
</${collapsibleTag}>
<p class="PlaygroundEditorTheme__paragraph" dir="auto">
<span data-lexical-text="true">after</span>
</p>
`,
);

await assertSelection(page, {
anchorOffset: 0,
anchorPath: [1, 1, 0],
focusOffset: 0,
focusPath: [1, 1, 0],
});

await moveUp(page, 1);
await assertSelection(page, {
anchorOffset: 0,
anchorPath: [1, 0, 0, 0, 0],
focusOffset: 0,
focusPath: [1, 0, 0, 0, 0],
});

await moveUp(page, 1);
await assertSelection(page, {
anchorOffset: 0,
anchorPath: [0, 0, 0],
focusOffset: 0,
focusPath: [0, 0, 0],
});
});

test(`Can't delete forward a Table`, async ({page, isPlainText}) => {
test.skip(isPlainText);
if (!IS_MAC) {
Expand Down
6 changes: 4 additions & 2 deletions packages/lexical-playground/__tests__/e2e/Tables.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,11 +1664,13 @@ test.describe.parallel('Tables', () => {
await page.keyboard.press('Enter');

const collapsibleOpeningTag =
browserName === 'chromium'
browserName === 'chromium' || browserName === 'firefox'
? '<div class="Collapsible__container" open="">'
: '<details class="Collapsible__container" open="">';
const collapsibleClosingTag =
browserName === 'chromium' ? '</div>' : '</details>';
browserName === 'chromium' || browserName === 'firefox'
? '</div>'
: '</details>';

await assertHTML(
page,
Expand Down
10 changes: 5 additions & 5 deletions packages/lexical-playground/src/plugins/CollapsibleExtension/CollapsibleContainerNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*
*/

import {IS_CHROME} from '@lexical/utils';
import {IS_CHROME, IS_FIREFOX} from '@lexical/utils';
import {
$getSiblingCaret,
$isElementNode,
Expand Down Expand Up @@ -85,9 +85,9 @@ export class CollapsibleContainerNode extends ElementNode {
}

createDOM(config: EditorConfig, editor: LexicalEditor): HTMLElement {
// details is not well supported in Chrome #5582
// details is not well supported in Chrome #5582 and Firefox #8348
let dom: HTMLElement;
if (IS_CHROME) {
if (IS_CHROME || IS_FIREFOX) {
dom = document.createElement('div');
dom.setAttribute('open', '');
} else {
Expand All @@ -109,8 +109,8 @@ export class CollapsibleContainerNode extends ElementNode {
updateDOM(prevNode: this, dom: HTMLDetailsElement): boolean {
const currentOpen = this.__open;
if (prevNode.__open !== currentOpen) {
// details is not well supported in Chrome #5582
if (IS_CHROME) {
// details is not well supported in Chrome #5582 and Firefox #8348
if (IS_CHROME || IS_FIREFOX) {
const contentDom = dom.children[1];
if (!isHTMLElement(contentDom)) {
throw new Error('Expected contentDom to be an HTMLElement');
Expand Down
4 changes: 2 additions & 2 deletions packages/lexical-playground/src/plugins/CollapsibleExtension/CollapsibleContentNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*
*/

import {IS_CHROME} from '@lexical/utils';
import {IS_CHROME, IS_FIREFOX} from '@lexical/utils';
import {
DOMConversionMap,
DOMConversionOutput,
Expand Down Expand Up @@ -44,7 +44,7 @@ export class CollapsibleContentNode extends ElementNode {
createDOM(config: EditorConfig, editor: LexicalEditor): HTMLElement {
const dom = document.createElement('div');
dom.classList.add('Collapsible__content');
if (IS_CHROME) {
if (IS_CHROME || IS_FIREFOX) {
editor.getEditorState().read(() => {
const containerNode = this.getParentOrThrow();
if (!$isCollapsibleContainerNode(containerNode)) {
Expand Down
4 changes: 2 additions & 2 deletions packages/lexical-playground/src/plugins/CollapsibleExtension/CollapsibleTitleNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*
*/

import {IS_CHROME} from '@lexical/utils';
import {IS_CHROME, IS_FIREFOX} from '@lexical/utils';
import {
$createParagraphNode,
$isElementNode,
Expand Down Expand Up @@ -54,7 +54,7 @@ export class CollapsibleTitleNode extends ElementNode {
createDOM(config: EditorConfig, editor: LexicalEditor): HTMLElement {
const dom = document.createElement('summary');
dom.classList.add('Collapsible__title');
if (IS_CHROME) {
if (IS_CHROME || IS_FIREFOX) {
dom.addEventListener('click', () => {
editor.update(() => {
const collapsibleContainer = this.getLatest().getParentOrThrow();
Expand Down
Loading