-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[lexical-code-core][lexical-playground] Feature: Create paragraph around the code node when navigating with the arrow keys #8393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
af8e4a1
insert paragraph from collaspsible-title if container are closed
levensta a87df47
add key handlers for creating fallback paragraphs
levensta f94fdb0
add tests for handlers
levensta d47874d
add config
levensta 7176493
Merge remote-tracking branch 'upstream/main' into escape-from-code
levensta b7a9147
Merge remote-tracking branch 'upstream/main' into escape-from-code
levensta 6fc33c1
move handlers to CodeIndentExtension and add backward-compatible tests
levensta 39366f8
reorganize tests and move handlers to lexical-utils
levensta c06a236
Merge remote-tracking branch 'upstream/main' into escape-from-code
levensta 60fb8b3
remove unused fn
levensta 472a586
some refactor and disable escaping in the code mode
levensta d0a4fd8
Merge branch 'main' into escape-from-code
levensta 09b3946
handle the edge of the ElementNode
levensta 9e6138c
Merge branch 'main' into escape-from-code
levensta 0aeba73
skip new tests in collab
levensta df21c2c
Merge remote-tracking branch 'upstream/main' into escape-from-code
levensta bdf3f65
Merge remote-tracking branch 'upstream/main' into escape-from-code
levensta 60bbc44
trigger selection explicitly
levensta d4ad4ae
Merge remote-tracking branch 'upstream/main' into escape-from-code
levensta d984af0
Merge remote-tracking branch 'upstream/main' into escape-from-code
levensta b0b8c49
Merge branch 'main' into escape-from-code
levensta 9bc369a
Merge branch 'main' into escape-from-code
etrepum f116ff1
add fallback for empty node
levensta 43a825e
Merge branch 'main' into escape-from-code
levensta 2aa1b6e
fix typo
levensta 29fba45
Merge branch 'main' into escape-from-code
levensta 8edb8d1
Merge branch 'main' into escape-from-code
levensta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are already up/down handlers in here you could just add this code to them in the right place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep the group of handlers for the
escapeWithArrowsparameter together and not mix the responsibilities of two different functions into one handlerOtherwise, it would look like this