[lexical-playground] Chore: Drop FIXME #8348 Firefox ArrowDown workaround in Tables.spec.mjs#8508
Merged
etrepum merged 1 commit intoMay 13, 2026
Conversation
…n workaround in Tables.spec.mjs Issue facebook#8348 (Firefox regression in up/down arrow key handling with collapsible) was fixed by facebook#8349 (merged 2026-04-14). Selection.spec.mjs now asserts arrow-nav into/out of collapsible content works in all browsers (facebook#8348). The Firefox-only ArrowRight workaround in Tables.spec.mjs is dead code that masks any future regression and obscures the test's intent (it's checking collapsible-newline behavior in tables, not arrow-key navigation).
markselby9
requested review from
acywatson,
etrepum,
fantactuka,
ivailop7,
potatowagon,
takuyakanbr and
zurfyx
as code owners
meta-cla
Bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #8348 (Firefox regression in up/down arrow key handling with collapsible) was fixed by #8349 (merged 2026-04-14). The same PR added
Selection.spec.mjs:703"Arrow keys navigate into/out of collapsible content in all browsers (#8348)", which asserts arrow-nav now works correctly in Firefox too.The Firefox-only
ArrowRightworkaround inTables.spec.mjsis now dead code — it masks any future regression and obscures the test's intent (this test is checking collapsible-newline behavior inside tables, not arrow-key navigation).Diff
await page.keyboard.type('123'); - await page.keyboard.press( - // FIXME #8348 firefox ArrowDown skips over the content block - browserName === 'firefox' ? 'ArrowRight' : 'ArrowDown', - ); + await page.keyboard.press('ArrowDown'); await page.keyboard.type('123');browserNamestays in the destructure — it's still used a few lines below for the Collapsible HTML-output check.Scope
One file, +1 / -4. No source / test-helper / CI changes.