Skip to content

fix issue #766 #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pprasse
Copy link

@pprasse pprasse commented Jan 6, 2018

This Pull-RQ fixes #766
The SESSION_TRACK_SYSTEM_VARIABLES field type was not backported, which led to incorrect handling when the system variable "character_set_client" changed (as was the case in #766 )

I also backported SESSION_TRACK_TRANSACTION_STATE, SESSION_TRACK_TRANSACTION_CHARACTERISTICS, SESSION_TRACK_SCHEMA as we should also handle those in accordance with the standard mysql client library.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@pprasse pprasse changed the title fixes https://github.com/facebook/mysql-5.6/issues/766 fix issue #766 Jan 6, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lth
Copy link
Contributor

lth commented Jan 11, 2018

I think a simpler fix is to remove the types from the switch statement and have it fall back to the default case which will handle unknown types correctly by skipping over them: https://github.com/Actindo/mysql-5.6/blob/bc6a6f44b3d4fabfa937d756057af996f3dbb1d6/sql-common/client.c#L893

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lth lth assigned lth and unassigned lth Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfault with 3.23.2 build of HHVM
3 participants