Skip to content

Conversation

@aaron-ang
Copy link
Contributor

@aaron-ang aaron-ang commented Jan 13, 2026

Summary

Resolve goto-definitions for submodule imports as aliases. Previously, only hover information was available.
For example,

from torch.nn import (
    attention as attention,
    functional as functional,
    init as init,
    modules as modules,
    parallel as parallel,
    parameter as parameter,
    utils as utils,
)

Test Plan

@meta-cla meta-cla bot added the cla signed label Jan 13, 2026
@github-actions

This comment has been minimized.

@aaron-ang aaron-ang marked this pull request as draft January 13, 2026 01:27
@github-actions
Copy link

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@aaron-ang aaron-ang marked this pull request as ready for review January 13, 2026 02:37
Copy link
Contributor

@stroxler stroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks reasonable to me, I'll aim to get a second review and merge

@meta-codesync
Copy link

meta-codesync bot commented Jan 13, 2026

@stroxler has imported this pull request. If you are a Meta employee, you can view this in D90599710.

Copy link
Contributor

@yangdanny97 yangdanny97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync bot closed this in a9c9a5f Jan 13, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 13, 2026

@stroxler merged this pull request in a9c9a5f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants