Skip to content

Restore the old mypy primer blocklist #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stroxler wants to merge 2 commits into from
Closed

Restore the old mypy primer blocklist #2713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe709cf
Use release builds for mypy primer
stroxler Mar 8, 2026
0cc2cff
Restore the old mypy primer blocklist
stroxler Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/mypy_primer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ jobs:
NEW_DIR=$BASE_DIR/pyrefly_new
mkdir -p $NEW_DIR
cd pyrefly_to_test && git checkout $GITHUB_SHA
CARGO_TARGET_DIR=$NEW_DIR/target cargo build --manifest-path pyrefly/Cargo.toml
BINARY_DIR=$NEW_DIR/target/debug
CARGO_TARGET_DIR=$NEW_DIR/target cargo build --release --manifest-path pyrefly/Cargo.toml
BINARY_DIR=$NEW_DIR/target/release
mv $BINARY_DIR/pyrefly $BINARY_DIR/pyrefly-real
cp scripts/pyrefly_primer_wrapper.sh $BINARY_DIR/pyrefly
chmod +x $BINARY_DIR/pyrefly
Expand All @@ -72,8 +72,8 @@ jobs:
OLD_DIR=$BASE_DIR/pyrefly_old
mkdir -p $OLD_DIR
git checkout base_commit
CARGO_TARGET_DIR=$OLD_DIR/target cargo build --manifest-path pyrefly/Cargo.toml
BINARY_DIR=$OLD_DIR/target/debug
CARGO_TARGET_DIR=$OLD_DIR/target cargo build --release --manifest-path pyrefly/Cargo.toml
BINARY_DIR=$OLD_DIR/target/release
mv $BINARY_DIR/pyrefly $BINARY_DIR/pyrefly-real
# Use the wrapper from the new commit (old commit may not have it)
git checkout $GITHUB_SHA -- scripts/pyrefly_primer_wrapper.sh
Expand All @@ -86,11 +86,11 @@ jobs:
MYPY_PRIMER_NO_REBUILD=1 mypy_primer \
--repo pyrefly_to_test \
--base-dir $BASE_DIR \
--cargo-profile dev \
--cargo-profile release \
--new $GITHUB_SHA --old base_commit \
--num-shards 10 --shard-index ${{ matrix.shard-index }} \
--debug \
--project-selector '.*' \
--project-selector '^(?!.*(python-attrs/attrs|scipy/scipy|scikit-learn/scikit-learn|pandas-dev/pandas|pandas-dev/pandas-stubs|apache/spark|spack/spack|sympy/sympy|PyCQA/flake8-pyi|Gobot1234/steam\.py|rotki/rotki|enthought/comtypes|pytest-dev/pytest|internetarchive/openlibrary|narwhals-dev/narwhals|ibis-project/ibis|trailofbits/manticore|dulwich/dulwich|freqtrade/freqtrade|pydata/xarray|schemathesis/schemathesis|pwndbg/pwndbg|graphql-python/graphql-core|davidhalter/parso))' \
--type-checker pyrefly \
--output concise \
| tee diff_${{ matrix.shard-index }}.txt
Expand Down