This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Add RelayPlugin #200
Merged
Add RelayPlugin #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kassens
force-pushed
the
relay
branch
2 times, most recently
from
4943bc3 to
0768cf8
Compare
kassens
force-pushed
the
relay
branch
2 times, most recently
from
4ca015b to
5298015
Compare
|
@yungsters @steveluscher @spicyj Thoughts on moving forward with this? |
| }); | ||
| }); | ||
| bridge.on('relay:success', ({id, response, end}) => { | ||
| console.log('response', id, response); |
Conflicts: agent/Bridge.js frontend/Panel.js frontend/SplitPane.js frontend/decorate.js
A better approach migtht be to implement a handshake on either the `Bridge` or `Wall` level that confirms that both sides are ready before sending anything.
Only show the Relay plugin for now as long as `location.hash` contains `relaydevtools`.
|
@yungsters and I thought it's best to land this (behind the URL toggle) and then iterate. |
|
At one point I had a settings tab see branch here, where I planned to allow users to enable/disable various plugins. That way you wouldn't need the location.hash thing. |
|
@jaredly: Yeah, I saw that but it didn't seem worth it for a single option. Once, we evolve the plugin a bit more, I think we can enable most things just when we see it's being used on the page. |
|
Other things that a settings page would be useful for: I agree that relay should only appear when it's detected though |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly @jaredly's work to add an initial plugin for Relay.
It currently includes #186, but I'll rebase once that's landed to clean this PR up.
I've fixed lint and flow issues as well as actually disabled this plugin by default. Since we don't have options yet, it's just commented out in
Panel.js.It's the beginning of #187.