forked from ChromeDevTools/devtools-frontend
-
Notifications
You must be signed in to change notification settings - Fork 9
Sync fork with chromium/7103 #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chromium pin updated to 136.0.7079.0 Roll created at https://cr-buildbucket.appspot.com/build/8719879389676520017 Bug: none Change-Id: Icf799ed3d6f0359472a841a0190dd08e291539c3 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375025 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Before: https://i.imgur.com/aVWAr49.png After: https://i.imgur.com/p3UWBUC.png Bug: 325443308 Change-Id: I603e8271493508855fabe33a45e08a36de35fbea Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375503 Reviewed-by: Kateryna Prokopenko <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]>
Fixed: 405049967 Change-Id: I4c254f2787a367d4dba8d96ae07c462a98f6f622 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375523 Reviewed-by: Ergün Erdoğmuş <[email protected]> Auto-Submit: Nikolay Vitkov <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]>
…eouts on bots Bug: 345556266 Change-Id: I8b1f95389bfb22d388747f6251a7959b44d1e294 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375263 Auto-Submit: Danil Somsikov <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]>
…ed diff view Bug: none Change-Id: I4aa03ebf9a89794d4ad36b029233ab44be59dadf Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376067 Commit-Queue: Ergün Erdoğmuş <[email protected]> Reviewed-by: Nikolay Vitkov <[email protected]> Commit-Queue: Nikolay Vitkov <[email protected]> Auto-Submit: Ergün Erdoğmuş <[email protected]>
Fixed: 404535134 Change-Id: Id1930b7023938154a1b46348b6c2170eab89d66c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368838 Reviewed-by: Eric Leese <[email protected]> Commit-Queue: Eric Leese <[email protected]> Auto-Submit: Philip Pfaffe <[email protected]>
includes `SyntheticNetworkRequests` Because tree views only consider events on the Main thread, we need to make an exception for when considering 3P (as this includes network requests). So on hover/click we should include network requests for completion using the entity mapper. https://screencast.googleplex.com/cast/NjIyNjk4NzE1OTkxMjQ0OHxjYzJhYjc2MS05Nw Bug: 394651390 Change-Id: I5d127a6dce58bd54a7fbbfeabd4401753b8f3bf8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6374483 Commit-Queue: Adriana Ixba <[email protected]> Reviewed-by: Paul Irish <[email protected]>
Bug: 394651390 Change-Id: I05d15ba3f0e2ff2e6a7b3fb9414f4cc5bba27557 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6373790 Commit-Queue: Adriana Ixba <[email protected]> Auto-Submit: Paul Irish <[email protected]> Reviewed-by: Adriana Ixba <[email protected]>
Specifically document the Linux specific limits for `inotify` which one can easily run into when combining `npm run build -- --watch` and VS code. Bug: 404192426 Change-Id: Idf301cb2e773325b2d299e61e879f85541551aa4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376063 Reviewed-by: Nikolay Vitkov <[email protected]> Auto-Submit: Benedikt Meurer <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
After dropping the `adoptedStyleSheets` the styles went missing for the interest group tab's empty state. This CL moves the rendering of the empty state into the main `render` method, under which we also include the correct styles. Before: https://i.imgur.com/N3xS6DM.png After: https://i.imgur.com/3W26pvn.png Bug: none Change-Id: If8eed04ec054e199d08053337cd3e6b2d3112c5e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376103 Commit-Queue: Benedikt Meurer <[email protected]> Auto-Submit: Kim-Anh Tran <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]>
Every call to `add` a new overlay would iterate over all existing overlays to manage singletons specially. For an extreme case of ~70k overlays, this resulted in ~22s of extra processing time on my M1 Mac. This CL reduces it down to 5ms by simply storing singleton overlays in a map for constant time lookup. Example trace w/ many overlays on 3p insight: https://trace.cafe/t/V7sS5bz7F0 Bug: 40278532 Change-Id: Ia8b76892e4f22f1a60215fffcc999fb4862121a0 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376737 Commit-Queue: Connor Clark <[email protected]> Auto-Submit: Connor Clark <[email protected]> Reviewed-by: Paul Irish <[email protected]>
Chromium pin updated to 136.0.7080.0 Roll created at https://cr-buildbucket.appspot.com/build/8719822769335182177 Bug: none Change-Id: Ie9c412cdf016ba0316c50e4e2fd9e4a1f2276bc3 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6377848 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
See bug for context, we sometimes see the LLM wrap its response in 5 backticks for no apparent reason. We're going to sync with the Aida folks to see if we can understand why or fix this on their side, but for now a fix is also to strip the 5 backticks if they are found in the response. Bug: 405054694 Change-Id: Ieb7499af142f7f7cba9ffea999729f49e1fbe536 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375525 Auto-Submit: Jack Franklin <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]>
Fixed: 405095525 Change-Id: I547dc6bb01c06a77147c2967fae1230dcb42a2eb Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376066 Reviewed-by: Simon Zünd <[email protected]> Auto-Submit: Ergün Erdoğmuş <[email protected]> Commit-Queue: Simon Zünd <[email protected]>
Fixed: 405061222 Change-Id: I3a7bc85e40512e3f9de244a0258377b9e3da2077 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375726 Commit-Queue: Jack Franklin <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]> Auto-Submit: Jack Franklin <[email protected]>
This has flaked a few times. Trying to see if this retry function will improve its stability, as we have quite a few rAFs to try to make this test work. Bug: 405356930 No-Presubmit: True No-Tree-Checks: True No-Try: True Change-Id: Ib9864aef67413ef1d3fa36d99359e8756b6626cb Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381858 Reviewed-by: Andres Olivares <[email protected]> Auto-Submit: Jack Franklin <[email protected]> Commit-Queue: Jack Franklin <[email protected]>
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8719788792218476385 [email protected] Bug: none Change-Id: Ic9b4442aecfc18ffaf55966d2737fe4ff870395b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381836 Reviewed-by: Jack Franklin <[email protected]> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Jack Franklin <[email protected]>
Fixed: 405061899 Change-Id: Idf06927221664dfa45a1ba3215fb5f2a6ad99084 Also-by: [email protected] Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381853 Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Jack Franklin <[email protected]> Auto-Submit: Jack Franklin <[email protected]>
Bug: none Change-Id: I819e3671f84eade93c5e3014a08b8b208cf4e5a6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382413 Commit-Queue: Nikolay Vitkov <[email protected]> Auto-Submit: Nikolay Vitkov <[email protected]> Commit-Queue: Kateryna Prokopenko <[email protected]> Reviewed-by: Kateryna Prokopenko <[email protected]>
Bug: none Change-Id: I88792c9561ab7950063335c9b949a7d10e6a5ae9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330113 Reviewed-by: Nancy Li <[email protected]> Commit-Queue: Nancy Li <[email protected]> Auto-Submit: Danil Somsikov <[email protected]>
Bug: none Change-Id: I44314f07516a6444b18bfc877efb1e0c0488fac8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383675 Reviewed-by: Andres Olivares <[email protected]> Auto-Submit: Jack Franklin <[email protected]> Commit-Queue: Andres Olivares <[email protected]> Commit-Queue: Jack Franklin <[email protected]>
Chromium pin updated to 136.0.7082.2 Roll created at https://cr-buildbucket.appspot.com/build/8719732170690310641 Bug: none Change-Id: I20016dec784528efaf22d90184e369d3bd1d1c7b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383277 Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Chromium pin updated to 136.0.7083.0 Roll created at https://cr-buildbucket.appspot.com/build/8719698197868596177 Bug: none Change-Id: I8c8977764f4698385a6df7b8a76034681273a06f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383824 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Chromium pin updated to 136.0.7084.0 Roll created at https://cr-buildbucket.appspot.com/build/8719641573921810753 Bug: none Change-Id: Ia627446634cb4cd1d0e27aed2c8b1d5604f621dc Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381661 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
… SWEs Change-Id: If356c1c17c13741ea8571a2ee47936aaa50e2bd7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367394 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Meysam Sarabadani <[email protected]> Reviewed-by: Danil Somsikov <[email protected]>
Fixed: 404535428 Change-Id: Ib6059ea7d278a172dc1e0880582a1a94bd255859 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372801 Reviewed-by: Eric Leese <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]>
Chromium pin updated to 136.0.7086.0 Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953 Bug: none Change-Id: I5e61d37fff280905844083c08c8306cb3a61876e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383222 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Rolling third_party/siso: git_revision:3a38836e06344016dce6092148a07a114807f9f0..git_revision:ae99e5f46d1fbc718ad9c28bb82c16883d7de99b Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953 Bug: none Change-Id: I91f43bb20ce1371651cf60f1f3cecd1ebb9e7102 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383221 Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bug: 388730998 Change-Id: Ida1c4b447a6086c5c0cad08dfc4f2c32e8323fb3 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382155 Auto-Submit: Danil Somsikov <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]>
This is better typed that the previous version. Bug: none Change-Id: I128ecbe730247676ef94460dfbcf8ef8aa1a9756 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383359 Reviewed-by: Benedikt Meurer <[email protected]> Auto-Submit: Nikolay Vitkov <[email protected]> Commit-Queue: Benedikt Meurer <[email protected]>
Partial revert of https://crrev.com/c/6293325 Bug: 409086863 Fixed: 410040501 Change-Id: I1b9f58ef3ee364af2c919df3162f2be1f7dcb143 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448573 Auto-Submit: Connor Clark <[email protected]> Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Connor Clark <[email protected]> (cherry picked from commit 5e20990) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455510 Commit-Queue: Paul Irish <[email protected]>
Bug: 409033193 Fixed: 409199516 Change-Id: I621d7ef22c8a63305e3b41bafc2106e59c33e9a7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6432956 Auto-Submit: Danil Somsikov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> (cherry picked from commit 31fc845) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455745
Bug: 408244902 Fixed: 409200069 Change-Id: I796e53b62a01219c84742373bf6e00c027f32560 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6436657 Reviewed-by: Philip Pfaffe <[email protected]> Auto-Submit: Danil Somsikov <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> (cherry picked from commit e8b639c) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456264
Bug: 408225523, 409188467 Change-Id: I371728da766b9a12393a925b0c54508bf3392d57 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6440816 Commit-Queue: Kateryna Prokopenko <[email protected]> Reviewed-by: Kateryna Prokopenko <[email protected]> Auto-Submit: Kim-Anh Tran <[email protected]> (cherry picked from commit 2816e66) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456625 Bot-Commit: Rubber Stamper <[email protected]>
Bug: 409325196 Fixed: 409341424 Change-Id: I1a51b5ed045b5a334a6407b693709c3cd12af67a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439041 Reviewed-by: Benedikt Meurer <[email protected]> Auto-Submit: Philip Pfaffe <[email protected]> Commit-Queue: Philip Pfaffe <[email protected]> (cherry picked from commit 93ebef8) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456626 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
Bug: 408225523 Fixed: 409188467 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439159 Reviewed-by: Kateryna Prokopenko <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]> Auto-Submit: Kim-Anh Tran <[email protected]> (cherry picked from commit a1dabaf) Change-Id: Ifd851a4507c2e34de36338a1b0bb538f24554ba6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456627 Bot-Commit: Rubber Stamper <[email protected]>
Note: This does not fix the behavior that the text of a tooltip is being selected if the anchor had an active text selection before hovering. Change-Id: I15135dfbb040ef60af83b00ac14df38c59d522f8 Bug: 409988275 Fixed: 410486388 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448276 Commit-Queue: Nikolay Vitkov <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> (cherry picked from commit e265def) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6458418 Auto-Submit: Nikolay Vitkov <[email protected]>
Bug: 408145209, 411315974 Change-Id: I25bc8902ea54c3dc994b9e00dce11351dc7221b7 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6430184 Auto-Submit: Eric Leese <[email protected]> Reviewed-by: Liviu Rau <[email protected]> Commit-Queue: Liviu Rau <[email protected]> Commit-Queue: Eric Leese <[email protected]> (cherry picked from commit e4c5ad5) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468181 Bot-Commit: Rubber Stamper <[email protected]>
Bug: 408145209 Fixed: 411315974 Change-Id: I7246d08a8ff033c081a141b49ded7070f977ddd6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429854 Commit-Queue: Eric Leese <[email protected]> Reviewed-by: Philip Pfaffe <[email protected]> Reviewed-by: Liviu Rau <[email protected]> (cherry picked from commit 9876f54) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468182 Bot-Commit: Rubber Stamper <[email protected]>
Bug: 409985196 Fixed: 410515701 Change-Id: Ie7d1cd7bd470faf8814689840c9436cdd64ef09f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6450702 Commit-Queue: Philip Pfaffe <[email protected]> Auto-Submit: Philip Pfaffe <[email protected]> Reviewed-by: Ergün Erdoğmuş <[email protected]> Commit-Queue: Ergün Erdoğmuş <[email protected]> (cherry picked from commit 5378490) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6461929 Bot-Commit: Rubber Stamper <[email protected]>
Bug: 411728380 Fixed: 412378555 Change-Id: Ibf062a17e1a6ba30d53dab9d7530dcf88b141917 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6472150 Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Connor Clark <[email protected]> Auto-Submit: Connor Clark <[email protected]> (cherry picked from commit 4ef47f3) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476926 Commit-Queue: Paul Irish <[email protected]>
Bug: 411285104 Fixed: 411310102 Change-Id: Icf309edf064a05a650b5d45754b58dfb7485347e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468177 Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Danil Somsikov <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Auto-Submit: Danil Somsikov <[email protected]> (cherry picked from commit 0b33e61) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476907 Auto-Submit: Connor Clark <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Rubber Stamper <[email protected]>
The UI was previously freezing when the user tries to render large values. We are now truncating the value to 4096 chars. Bug: 408976043 Fixed: 410744529 Change-Id: I75fec294ae474b6cc5871fc5c9c6e722561b122a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455747 Commit-Queue: Benedikt Meurer <[email protected]> Auto-Submit: Danil Somsikov <[email protected]> Reviewed-by: Benedikt Meurer <[email protected]> (cherry picked from commit b75904f) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476906 Commit-Queue: Rubber Stamper <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Paul Irish <[email protected]> Auto-Submit: Connor Clark <[email protected]>
Bug: 410511500 Fixed: 412033240 Change-Id: I78c45a79d7a26ca0bd838a7c25352934e8e38ae0 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6454343 Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Changhao Han <[email protected]> (cherry picked from commit 272fb83) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6475146 Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Commit-Queue: Simon Zünd <[email protected]> Commit-Queue: Paul Irish <[email protected]> Reviewed-by: Paul Irish <[email protected]> Auto-Submit: Changhao Han <[email protected]>
Bug: 409771454 Change-Id: I19e9840d78ee245c1a15b5d8e65485eb227d4aa1 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6459230 Reviewed-by: Kim-Anh Tran <[email protected]> Commit-Queue: Kateryna Prokopenko <[email protected]> Auto-Submit: Kateryna Prokopenko <[email protected]> Commit-Queue: Kim-Anh Tran <[email protected]> (cherry picked from commit 199588f) Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6513135
…-sync # Conflicts: # .gitignore # CONTRIBUTING.md # README.md # config/gni/devtools_grd_files.gni # front_end/BUILD.gn # front_end/core/root/Runtime.ts # front_end/core/sdk/Connections.ts # front_end/core/sdk/PageResourceLoader.ts # front_end/core/sdk/sdk-meta.ts # front_end/core/sdk/sdk.ts # front_end/entrypoints/inspector_main/BUILD.gn # front_end/entrypoints/main/BUILD.gn # front_end/entrypoints/main/MainImpl.ts # front_end/entrypoints/shell/BUILD.gn # front_end/models/source_map_scopes/NamesResolver.test.ts # front_end/models/source_map_scopes/NamesResolver.ts # front_end/models/timeline_model/TimelineModelFilter.test.ts # front_end/models/trace/handlers/RendererHandler.ts # front_end/models/trace/handlers/WarningsHandler.test.ts # front_end/models/trace/helpers/SyntheticEvents.test.ts # front_end/models/trace/insights/CumulativeLayoutShift.test.ts # front_end/models/trace/insights/DocumentLatency.test.ts # front_end/models/trace/insights/InteractionToNextPaint.test.ts # front_end/models/trace/insights/LargestContentfulPaint.test.ts # front_end/models/trace/lantern/core/NetworkAnalyzer.test.ts # front_end/panels/console/ErrorStackParser.test.ts # front_end/panels/console/consoleView.css # front_end/panels/network/NetworkLogView.ts # front_end/panels/network/NetworkPanel.ts # front_end/panels/network/network-meta.ts # front_end/panels/profiler/HeapSnapshotView.ts # front_end/panels/sources/SourcesView.ts # front_end/panels/sources/UISourceCodeFrame.ts # front_end/panels/timeline/EntriesFilter.test.ts # front_end/panels/timeline/Initiators.test.ts # front_end/panels/timeline/ModificationsManager.test.ts # front_end/panels/timeline/TimelineFlameChartDataProvider.ts # front_end/panels/timeline/TimelineLandingPage.ts # front_end/panels/timeline/TimelinePanel.ts # front_end/panels/timeline/TimingsTrackAppender.ts # front_end/testing/EnvironmentHelpers.ts # front_end/third_party/additional_readme_paths.json # front_end/ui/components/input/checkbox.css # front_end/ui/legacy/ActionRegistration.ts # front_end/ui/legacy/BUILD.gn # front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts # front_end/ui/legacy/components/utils/TargetDetachedDialog.ts # front_end/ui/legacy/inspectorCommon.css # front_end/ui/legacy/remoteDebuggingTerminatedScreen.css # front_end/ui/legacy/theme_support/ThemeSupport.ts # scripts/eslint_rules/lib/check-license-header.js # third_party/node/node.py
f270410
to
2db3f51
Compare
7bd8f3d
to
0cae7db
Compare
0cae7db
to
3f97884
Compare
Replaced with #170. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.