Skip to content

Update textinput autocomplete #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 17, 2021
Merged

Update textinput autocomplete #1184

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
734e73e
autoCompleteType prop in textInput has been renamed to autoComplete
jeswinsimon Aug 9, 2019
663466b
Updated hyperlink
jeswinsimon Aug 9, 2019
b0a5297
Merge pull request #1 from facebook/master
jeswinsimon Nov 29, 2019
0022d7b
Merge branch 'facebook:master' into master
jeswinsimon Jul 20, 2021
510f032
Merge from master
jeswinsimon Jul 20, 2021
4e1d6fd
Merge branch 'facebook:master' into master
jeswinsimon Jul 30, 2021
041a79a
Merge from master
jeswinsimon Jul 30, 2021
8aa77ff
Merge from master
jeswinsimon Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/textinput.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,11 @@ Tells `TextInput` to automatically capitalize certain characters. This property

---

### `autoCompleteType` <div class="label android">Android</div>
### `autoComplete` <div class="label android">Android</div>

Specifies autocomplete hints for the system, so it can provide autofill. On Android, the system will always attempt to offer autofill by using heuristics to identify the type of content. To disable autocomplete, set `autoCompleteType` to `off`.
Specifies autocomplete hints for the system, so it can provide autofill. On Android, the system will always attempt to offer autofill by using heuristics to identify the type of content. To disable autocomplete, set `autoComplete` to `off`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add one of those platform tags since this is an android only property?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like the green tag here: https://reactnative.dev/docs/next/text#datadetectortype-android

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeswinsimon In #2708 @luism3861 just added the missing platform labels for TextImput docs, it would be nice if you can rebase your PR and add the platform label as Luna suggested. 🙂


Possible values for `autoCompleteType` are:
Possible values for `autoComplete` are:

- `off`
- `username`
Expand Down