-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Closed
Labels
BugStaleThere has been a lack of activity on this issue and it may be closed soon.There has been a lack of activity on this issue and it may be closed soon.
Description
🐛 Bug Report
URL
polyfill in React Native
0.59 is broken because it's not compliant to WHATWG URL Standard. And it's broken even for the simplest use cases.
To Reproduce
const url = new URL('https://facebook.github.io/react-native/img/header_logo.png');
console.log(url);
Expected Behavior
https://facebook.github.io/react-native/img/header_logo.png
Actual Behavior
https://facebook.github.io/react-native/img/header_logo.png/
Note the trailing slash causes the URL points to a 404 page.
Environment
React Native Environment Info:
System:
OS: macOS 10.14.4
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 823.64 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.15.0
Yarn: 1.15.2
npm: 6.5.0
Watchman: 4.9.0
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 28
Build Tools: 28.0.3
System Images: android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.3 AI-182.5107.16.33.5314842
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.4 => 0.59.4
Possible Cause
react-native/Libraries/Blob/URL.js
Lines 146 to 149 in 65033d7
this._url = url; | |
if (!this._url.endsWith('/')) { | |
this._url += '/'; | |
} |
This code was introduced in #22901 .
redreceipt, timbicker, vzts, jalbertsr, AbdellahAitAabdelmalek and 4 more
Metadata
Metadata
Assignees
Labels
BugStaleThere has been a lack of activity on this issue and it may be closed soon.There has been a lack of activity on this issue and it may be closed soon.