Breaking: Ignore StatusBarManager rejected state

[leeight]

See #10236

[facebook-github-bot]

By analyzing the blame information on this pull request, we identified @spicyj and @alwx to be potential reviewers.

[janicduplessis]

Thinking about this more (sorry), we should just get rid of the promise. iOS doesn't have that and it's only used to report the error back to JS, but then we won't event use it.

We could just log it instead in native and do nothing with something like:

FLog.w(ReactConstants.TAG, "StatusBarModule: Ignored status bar change, current activity is null.");

[leeight]

@janicduplessis You mean change the method signature and remove final Promise res, so that make it consistent with iOS?

public void setHidden(final boolean hidden, final Promise res) { --> public void setHidden(final boolean hidden) {

[facebook-github-bot]

@leeight updated the pull request - view changes

[janicduplessis]

Yes, it's a breaking change but I doubt anyone was using the promise.

[janicduplessis]

LGTM, let's wait a bit see if someone has something to add. If not I'll shipit.

[leeight]

@janicduplessis Could you shipit?

[janicduplessis]

@facebook-github-bot shipit

[satya164]

Just a reminder, if anyone is merging any breaking change, please change the commit message to include breaking so we can find it when writing the release notes.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[facebook-github-bot]

@leeight updated the pull request - view changes - changes since last import

[leeight]

@janicduplessis Is there anything else i can do to fix the merge failed issue?

[janicduplessis]

@leeight Not sure why it failed lets just try it again

@facebook-github-bot shipit

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[leeight]

@janicduplessis I guess some FB internal test cases failed, maybe we shouldn't change the method signature. Could you help me check the internal logs? Or we should ignore rejected state in StatusBar.js but keep StatusBarModule.java the same.

[janicduplessis]

@foghina Could you have a look at why internal tests are failing?

[gotounix]

When this commit will be merged into master, and when will be merged into a release version?

[leeight]

@janicduplessis How about try it in another way? Fix it in the JS side, and don't change the java method signature?

[satya164]

cc @bestander

[bestander]

@facebook-github-bot import

[bestander]

Hm. of course, look at the Circle CI log:

/home/ubuntu/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/statusbar/StatusBarModule.java:23: error: package com.facebook.common.logging does not exist
import com.facebook.common.logging.FLog;

[bestander]

You need to change Buck file

[janicduplessis]

Ugh, how did I miss that -_- thanks @bestander !

[leeight]

Thanks @bestander, DONE.

[leeight]

PING

[bestander]

@facebook-github-bot shipit