bump android gradle plugin to 3.3.0 #22988
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
dulmandakh
requested review from
gengjiawen and
hramos
and removed request for
hramos
gengjiawen
approved these changes
Jan 15, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 15, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@dulmandakh merged commit b98964b into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Android Gradle Plugin 3.3.0 add many improvements in compile time speed, but also enable R8 shrinker. Changelog: ---------- [Android] [Changed] - Bump Android Gradle Plugin to 3.3.0 Pull Request resolved: facebook#22988 Differential Revision: D13676104 Pulled By: hramos fbshipit-source-id: 5a3834e64816222ee8a4aa6682c07ac6857fc5f6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Gradle Plugin 3.3.0 add many improvements in compile time speed, but also enable R8 shrinker.
Changelog:
[Android] [Changed] - Bump Android Gradle Plugin to 3.3.0
Test Plan:
Everything should work as before