[Android] Convert NetworkModule to Kotlin, mark methods as final #50705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72731227 |
Abbondanzo
changed the title
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72731227 |
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Apr 14, 2025
…ain/java/com/facebook/react/modules/network/NetworkingModule.java (facebook#50705) Summary: Pull Request resolved: facebook#50705 Changelog: [Android][Breaking] - Convert NetworkModule to Kotlin, mark methods as final Differential Revision: D72731227
Abbondanzo
force-pushed
the
export-D72731227
branch
from
07923c3 to
f60e842
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72731227 |
Abbondanzo
force-pushed
the
export-D72731227
branch
from
f60e842 to
98fb23a
Compare
Abbondanzo
added a commit
to Abbondanzo/react-native
that referenced
this pull request
Apr 14, 2025
…ain/java/com/facebook/react/modules/network/NetworkingModule.java (facebook#50705) Summary: Pull Request resolved: facebook#50705 Changelog: [Android][Breaking] - Convert NetworkModule to Kotlin, mark methods as final Reviewed By: mlord93 Differential Revision: D72731227
…ain/java/com/facebook/react/modules/network/NetworkingModule.java (facebook#50705) Summary: Pull Request resolved: facebook#50705 Changelog: [Android][Breaking] - Convert NetworkModule to Kotlin, mark methods as final Reviewed By: mlord93 Differential Revision: D72731227
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72731227 |
Abbondanzo
force-pushed
the
export-D72731227
branch
from
98fb23a to
6882ba8
Compare
Contributor
|
This pull request has been merged in 8726e26. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in 8726e26 When will my fix make it into a release? | How to file a pick request? |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
…ain/java/com/facebook/react/modules/network/NetworkingModule.java (facebook#50705) Summary: Pull Request resolved: facebook#50705 Changelog: [Android][Breaking] - Convert NetworkModule to Kotlin, mark methods as final Reviewed By: mlord93 Differential Revision: D72731227 fbshipit-source-id: 80569f1cc88754492f48fca558db7eab3e1c28b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Android][Breaking] - Convert NetworkModule to Kotlin, mark methods as final
Differential Revision: D72731227