-
Notifications
You must be signed in to change notification settings - Fork 25k
Add warning when app is running with the old architecture #50735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73041156 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Apr 15, 2025
…0735) Summary: This change adds a warning in JS that is printed when the app is running using the old architecture. The assumption is that, if it is running with Fabric, it is running with the new architecture. So running without Fabric implies old architecture. ## Changelog: [General][Added] - Add warning when the app runs with the legacy architecture Reviewed By: cortinico Differential Revision: D73041156
17671c9 to
d21a618
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73041156 |
d21a618 to
f48eb27
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Apr 16, 2025
…0735) Summary: This change adds a warning in JS that is printed when the app is running using the old architecture. The assumption is that, if it is running with Fabric, it is running with the new architecture. So running without Fabric implies old architecture. ## Changelog: [General][Added] - Add warning when the app runs with the legacy architecture Reviewed By: cortinico, rubennorte Differential Revision: D73041156
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73041156 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Apr 16, 2025
…0735) Summary: Pull Request resolved: facebook#50735 This change adds a warning in JS that is printed when the app is running using the old architecture. The assumption is that, if it is running with Fabric, it is running with the new architecture. So running without Fabric implies old architecture. ## Changelog: [General][Added] - Add warning when the app runs with the legacy architecture Reviewed By: cortinico, rubennorte Differential Revision: D73041156
f48eb27 to
0c1adf5
Compare
…0735) Summary: This change adds a warning in JS that is printed when the app is running using the old architecture. The assumption is that, if it is running with Fabric, it is running with the new architecture. So running without Fabric implies old architecture. ## Changelog: [General][Added] - Add warning when the app runs with the legacy architecture Reviewed By: cortinico, rubennorte Differential Revision: D73041156
0c1adf5 to
e18eb70
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73041156 |
Contributor
|
This pull request has been merged in 706b6e8. |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
…0735) Summary: Pull Request resolved: facebook#50735 This change adds a warning in JS that is printed when the app is running using the old architecture. The assumption is that, if it is running with Fabric, it is running with the new architecture. So running without Fabric implies old architecture. ## Changelog: [General][Added] - Add warning when the app runs with the legacy architecture Reviewed By: cortinico, rubennorte Differential Revision: D73041156 fbshipit-source-id: 89a14f6370ae54b9d115e0ef672f29084d009a8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds a warning in JS that is printed when the app is running using the old architecture.
The assumption is that, if it is running with Fabric, it is running with the new architecture. So running without Fabric implies old architecture.
Changelog:
[General][Added] - Add warning when the app runs with the legacy architecture
Reviewed By: cortinico
Differential Revision: D73041156