Expose ReactNativeVersion API #52784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78806347 |
|
Summary: Resolves react-native-community/discussions-and-proposals#893 (comment). **Changes** - Formalises the design of `ReactNativeVersion` as a single object and adds a `getVersionString` accessor. - Expose `ReactNativeVersion` as a root export on `index.js`. - Update deep imports use in `NewAppScreen`. **Notes** - Subtly, we also have `Platform.constants.reactNativeVersion` in our public API already. **However**, this is the per-platform ***native-reported*** RN version, distinct from the JS version (this diff). See [`ReactNativeVersionCheck.js`](https://github.com/facebook/react-native/blob/54d733311d87e9ab4e18f947edf3f5c85f9a6275/packages/react-native/Libraries/Core/ReactNativeVersionCheck.js#L24). Changelog: [General][Added] - Expose `ReactNativeVersion` API as JavaScript root export Differential Revision: D78806347
|
This pull request was exported from Phabricator. Differential Revision: D78806347 |
|
This pull request has been merged in ec5638a. |
|
This pull request was successfully merged by @huntie in ec5638a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves react-native-community/discussions-and-proposals#893 (comment).
Changes
ReactNativeVersionas a single object and adds agetVersionStringaccessor.ReactNativeVersionas a root export onindex.js.NewAppScreen.Notes
Platform.constants.reactNativeVersionin our public API already. However, this is the per-platform native-reported RN version, distinct from the JS version (this diff). SeeReactNativeVersionCheck.js.Changelog:
[General][Added] - Expose
ReactNativeVersionAPI as JavaScript root exportDifferential Revision: D78806347