Skip to content

Commit 1622d0f

Browse files
potetopoteto
committed
[crud] Remove useResourceEffect (#32206)
Removes useResourceEffect. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32206). * __->__ #32206 * #32205 DiffTrain build for [a69b80d](a69b80d)
1 parent 64c08bd commit 1622d0f

37 files changed

+6486
-6765
lines changed

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0461c0d8a49730d1c8ebca2071d9bb7adfc8ac92
1+
a69b80d07e5d1bf363ed15d6209a55b35e0765c2

‎compiled/facebook-www/REVISION_TRANSFORMS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0461c0d8a49730d1c8ebca2071d9bb7adfc8ac92
1+
a69b80d07e5d1bf363ed15d6209a55b35e0765c2

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,22 +1011,6 @@ __DEV__ &&
10111011
function useMemoCache(size) {
10121012
return resolveDispatcher().useMemoCache(size);
10131013
}
1014-
function useResourceEffect(
1015-
create,
1016-
createDeps,
1017-
update,
1018-
updateDeps,
1019-
destroy
1020-
) {
1021-
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
1022-
return resolveDispatcher().useResourceEffect(
1023-
create,
1024-
createDeps,
1025-
update,
1026-
updateDeps,
1027-
destroy
1028-
);
1029-
}
10301014
function noop() {}
10311015
function enqueueTask(task) {
10321016
if (null === enqueueTaskImpl)
@@ -1333,10 +1317,7 @@ __DEV__ &&
13331317
);
13341318
return children;
13351319
}
1336-
},
1337-
experimental_useResourceEffect = enableUseEffectCRUDOverload
1338-
? useResourceEffect
1339-
: void 0;
1320+
};
13401321
exports.captureOwnerStack = void 0;
13411322
enableOwnerStacks && (exports.captureOwnerStack = captureOwnerStack);
13421323
exports.Children = Children;
@@ -1703,7 +1684,6 @@ __DEV__ &&
17031684
exports.experimental_useEffectEvent = function (callback) {
17041685
return resolveDispatcher().useEffectEvent(callback);
17051686
};
1706-
exports.experimental_useResourceEffect = experimental_useResourceEffect;
17071687
exports.forwardRef = function (render) {
17081688
null != render && render.$$typeof === REACT_MEMO_TYPE
17091689
? error$jscomp$0(
@@ -1928,8 +1908,30 @@ __DEV__ &&
19281908
exports.useDeferredValue = function (value, initialValue) {
19291909
return resolveDispatcher().useDeferredValue(value, initialValue);
19301910
};
1931-
exports.useEffect = function (create, deps) {
1932-
return resolveDispatcher().useEffect(create, deps);
1911+
exports.useEffect = function (
1912+
create,
1913+
createDeps,
1914+
update,
1915+
updateDeps,
1916+
destroy
1917+
) {
1918+
var dispatcher = resolveDispatcher();
1919+
if (
1920+
enableUseEffectCRUDOverload &&
1921+
("function" === typeof update || "function" === typeof destroy)
1922+
)
1923+
return dispatcher.useEffect(
1924+
create,
1925+
createDeps,
1926+
update,
1927+
updateDeps,
1928+
destroy
1929+
);
1930+
if ("function" === typeof update)
1931+
throw Error(
1932+
"useEffect CRUD overload is not enabled in this build of React."
1933+
);
1934+
return dispatcher.useEffect(create, createDeps);
19331935
};
19341936
exports.useId = function () {
19351937
return resolveDispatcher().useId();
@@ -1972,7 +1974,7 @@ __DEV__ &&
19721974
exports.useTransition = function () {
19731975
return resolveDispatcher().useTransition();
19741976
};
1975-
exports.version = "19.1.0-www-classic-0461c0d8-20250211";
1977+
exports.version = "19.1.0-www-classic-a69b80d0-20250211";
19761978
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19771979
"function" ===
19781980
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,22 +1011,6 @@ __DEV__ &&
10111011
function useMemoCache(size) {
10121012
return resolveDispatcher().useMemoCache(size);
10131013
}
1014-
function useResourceEffect(
1015-
create,
1016-
createDeps,
1017-
update,
1018-
updateDeps,
1019-
destroy
1020-
) {
1021-
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
1022-
return resolveDispatcher().useResourceEffect(
1023-
create,
1024-
createDeps,
1025-
update,
1026-
updateDeps,
1027-
destroy
1028-
);
1029-
}
10301014
function noop() {}
10311015
function enqueueTask(task) {
10321016
if (null === enqueueTaskImpl)
@@ -1333,10 +1317,7 @@ __DEV__ &&
13331317
);
13341318
return children;
13351319
}
1336-
},
1337-
experimental_useResourceEffect = enableUseEffectCRUDOverload
1338-
? useResourceEffect
1339-
: void 0;
1320+
};
13401321
exports.captureOwnerStack = void 0;
13411322
enableOwnerStacks && (exports.captureOwnerStack = captureOwnerStack);
13421323
exports.Children = Children;
@@ -1703,7 +1684,6 @@ __DEV__ &&
17031684
exports.experimental_useEffectEvent = function (callback) {
17041685
return resolveDispatcher().useEffectEvent(callback);
17051686
};
1706-
exports.experimental_useResourceEffect = experimental_useResourceEffect;
17071687
exports.forwardRef = function (render) {
17081688
null != render && render.$$typeof === REACT_MEMO_TYPE
17091689
? error$jscomp$0(
@@ -1928,8 +1908,30 @@ __DEV__ &&
19281908
exports.useDeferredValue = function (value, initialValue) {
19291909
return resolveDispatcher().useDeferredValue(value, initialValue);
19301910
};
1931-
exports.useEffect = function (create, deps) {
1932-
return resolveDispatcher().useEffect(create, deps);
1911+
exports.useEffect = function (
1912+
create,
1913+
createDeps,
1914+
update,
1915+
updateDeps,
1916+
destroy
1917+
) {
1918+
var dispatcher = resolveDispatcher();
1919+
if (
1920+
enableUseEffectCRUDOverload &&
1921+
("function" === typeof update || "function" === typeof destroy)
1922+
)
1923+
return dispatcher.useEffect(
1924+
create,
1925+
createDeps,
1926+
update,
1927+
updateDeps,
1928+
destroy
1929+
);
1930+
if ("function" === typeof update)
1931+
throw Error(
1932+
"useEffect CRUD overload is not enabled in this build of React."
1933+
);
1934+
return dispatcher.useEffect(create, createDeps);
19331935
};
19341936
exports.useId = function () {
19351937
return resolveDispatcher().useId();
@@ -1972,7 +1974,7 @@ __DEV__ &&
19721974
exports.useTransition = function () {
19731975
return resolveDispatcher().useTransition();
19741976
};
1975-
exports.version = "19.1.0-www-modern-0461c0d8-20250211";
1977+
exports.version = "19.1.0-www-modern-a69b80d0-20250211";
19761978
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19771979
"function" ===
19781980
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -325,16 +325,6 @@ function lazyInitializer(payload) {
325325
function useMemoCache(size) {
326326
return ReactSharedInternals.H.useMemoCache(size);
327327
}
328-
function useResourceEffect(create, createDeps, update, updateDeps, destroy) {
329-
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
330-
return ReactSharedInternals.H.useResourceEffect(
331-
create,
332-
createDeps,
333-
update,
334-
updateDeps,
335-
destroy
336-
);
337-
}
338328
var reportGlobalError =
339329
"function" === typeof reportError
340330
? reportError
@@ -365,10 +355,7 @@ var reportGlobalError =
365355
console.error(error);
366356
};
367357
function noop() {}
368-
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache },
369-
experimental_useResourceEffect = enableUseEffectCRUDOverload
370-
? useResourceEffect
371-
: void 0;
358+
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache };
372359
exports.Children = {
373360
map: mapChildren,
374361
forEach: function (children, forEachFunc, forEachContext) {
@@ -512,7 +499,6 @@ exports.createRef = function () {
512499
exports.experimental_useEffectEvent = function (callback) {
513500
return ReactSharedInternals.H.useEffectEvent(callback);
514501
};
515-
exports.experimental_useResourceEffect = experimental_useResourceEffect;
516502
exports.forwardRef = function (render) {
517503
return { $$typeof: REACT_FORWARD_REF_TYPE, render: render };
518504
};
@@ -595,8 +581,24 @@ exports.useDebugValue = function () {};
595581
exports.useDeferredValue = function (value, initialValue) {
596582
return ReactSharedInternals.H.useDeferredValue(value, initialValue);
597583
};
598-
exports.useEffect = function (create, deps) {
599-
return ReactSharedInternals.H.useEffect(create, deps);
584+
exports.useEffect = function (create, createDeps, update, updateDeps, destroy) {
585+
var dispatcher = ReactSharedInternals.H;
586+
if (
587+
enableUseEffectCRUDOverload &&
588+
("function" === typeof update || "function" === typeof destroy)
589+
)
590+
return dispatcher.useEffect(
591+
create,
592+
createDeps,
593+
update,
594+
updateDeps,
595+
destroy
596+
);
597+
if ("function" === typeof update)
598+
throw Error(
599+
"useEffect CRUD overload is not enabled in this build of React."
600+
);
601+
return dispatcher.useEffect(create, createDeps);
600602
};
601603
exports.useId = function () {
602604
return ReactSharedInternals.H.useId();
@@ -639,4 +641,4 @@ exports.useSyncExternalStore = function (
639641
exports.useTransition = function () {
640642
return ReactSharedInternals.H.useTransition();
641643
};
642-
exports.version = "19.1.0-www-classic-0461c0d8-20250211";
644+
exports.version = "19.1.0-www-classic-a69b80d0-20250211";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -325,16 +325,6 @@ function lazyInitializer(payload) {
325325
function useMemoCache(size) {
326326
return ReactSharedInternals.H.useMemoCache(size);
327327
}
328-
function useResourceEffect(create, createDeps, update, updateDeps, destroy) {
329-
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
330-
return ReactSharedInternals.H.useResourceEffect(
331-
create,
332-
createDeps,
333-
update,
334-
updateDeps,
335-
destroy
336-
);
337-
}
338328
var reportGlobalError =
339329
"function" === typeof reportError
340330
? reportError
@@ -365,10 +355,7 @@ var reportGlobalError =
365355
console.error(error);
366356
};
367357
function noop() {}
368-
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache },
369-
experimental_useResourceEffect = enableUseEffectCRUDOverload
370-
? useResourceEffect
371-
: void 0;
358+
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache };
372359
exports.Children = {
373360
map: mapChildren,
374361
forEach: function (children, forEachFunc, forEachContext) {
@@ -512,7 +499,6 @@ exports.createRef = function () {
512499
exports.experimental_useEffectEvent = function (callback) {
513500
return ReactSharedInternals.H.useEffectEvent(callback);
514501
};
515-
exports.experimental_useResourceEffect = experimental_useResourceEffect;
516502
exports.forwardRef = function (render) {
517503
return { $$typeof: REACT_FORWARD_REF_TYPE, render: render };
518504
};
@@ -595,8 +581,24 @@ exports.useDebugValue = function () {};
595581
exports.useDeferredValue = function (value, initialValue) {
596582
return ReactSharedInternals.H.useDeferredValue(value, initialValue);
597583
};
598-
exports.useEffect = function (create, deps) {
599-
return ReactSharedInternals.H.useEffect(create, deps);
584+
exports.useEffect = function (create, createDeps, update, updateDeps, destroy) {
585+
var dispatcher = ReactSharedInternals.H;
586+
if (
587+
enableUseEffectCRUDOverload &&
588+
("function" === typeof update || "function" === typeof destroy)
589+
)
590+
return dispatcher.useEffect(
591+
create,
592+
createDeps,
593+
update,
594+
updateDeps,
595+
destroy
596+
);
597+
if ("function" === typeof update)
598+
throw Error(
599+
"useEffect CRUD overload is not enabled in this build of React."
600+
);
601+
return dispatcher.useEffect(create, createDeps);
600602
};
601603
exports.useId = function () {
602604
return ReactSharedInternals.H.useId();
@@ -639,4 +641,4 @@ exports.useSyncExternalStore = function (
639641
exports.useTransition = function () {
640642
return ReactSharedInternals.H.useTransition();
641643
};
642-
exports.version = "19.1.0-www-modern-0461c0d8-20250211";
644+
exports.version = "19.1.0-www-modern-a69b80d0-20250211";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -329,16 +329,6 @@ function lazyInitializer(payload) {
329329
function useMemoCache(size) {
330330
return ReactSharedInternals.H.useMemoCache(size);
331331
}
332-
function useResourceEffect(create, createDeps, update, updateDeps, destroy) {
333-
if (!enableUseEffectCRUDOverload) throw Error("Not implemented.");
334-
return ReactSharedInternals.H.useResourceEffect(
335-
create,
336-
createDeps,
337-
update,
338-
updateDeps,
339-
destroy
340-
);
341-
}
342332
var reportGlobalError =
343333
"function" === typeof reportError
344334
? reportError
@@ -369,10 +359,7 @@ var reportGlobalError =
369359
console.error(error);
370360
};
371361
function noop() {}
372-
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache },
373-
experimental_useResourceEffect = enableUseEffectCRUDOverload
374-
? useResourceEffect
375-
: void 0;
362+
var ReactCompilerRuntime = { __proto__: null, c: useMemoCache };
376363
exports.Children = {
377364
map: mapChildren,
378365
forEach: function (children, forEachFunc, forEachContext) {
@@ -516,7 +503,6 @@ exports.createRef = function () {
516503
exports.experimental_useEffectEvent = function (callback) {
517504
return ReactSharedInternals.H.useEffectEvent(callback);
518505
};
519-
exports.experimental_useResourceEffect = experimental_useResourceEffect;
520506
exports.forwardRef = function (render) {
521507
return { $$typeof: REACT_FORWARD_REF_TYPE, render: render };
522508
};
@@ -599,8 +585,24 @@ exports.useDebugValue = function () {};
599585
exports.useDeferredValue = function (value, initialValue) {
600586
return ReactSharedInternals.H.useDeferredValue(value, initialValue);
601587
};
602-
exports.useEffect = function (create, deps) {
603-
return ReactSharedInternals.H.useEffect(create, deps);
588+
exports.useEffect = function (create, createDeps, update, updateDeps, destroy) {
589+
var dispatcher = ReactSharedInternals.H;
590+
if (
591+
enableUseEffectCRUDOverload &&
592+
("function" === typeof update || "function" === typeof destroy)
593+
)
594+
return dispatcher.useEffect(
595+
create,
596+
createDeps,
597+
update,
598+
updateDeps,
599+
destroy
600+
);
601+
if ("function" === typeof update)
602+
throw Error(
603+
"useEffect CRUD overload is not enabled in this build of React."
604+
);
605+
return dispatcher.useEffect(create, createDeps);
604606
};
605607
exports.useId = function () {
606608
return ReactSharedInternals.H.useId();
@@ -643,7 +645,7 @@ exports.useSyncExternalStore = function (
643645
exports.useTransition = function () {
644646
return ReactSharedInternals.H.useTransition();
645647
};
646-
exports.version = "19.1.0-www-classic-0461c0d8-20250211";
648+
exports.version = "19.1.0-www-classic-a69b80d0-20250211";
647649
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
648650
"function" ===
649651
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)