Context update doesn't fully propagate in some cases

[gaearon]

I think there may be a bug in context in the latest alpha. When some updates are scheduled in the commit phase, it doesn't seem to propagate.

git clone https://github.com/gaearon/emoji-search.git
cd emoji-search
yarn
yarn start

Enter "mon". Erase it. Click on "dark mode".
Expected: all children update. Actual: some children don't update.

This only seems to happen with this indirection.

[AlexanderKositsyn]

@gaearon I solved this bug for particular task by changing the 'key' props for each EmojiResultRow item from title to index. This is bad decision. But the bug maybe in Provider reconciliation.
New code from EmojiResults

class EmojiResults extends PureComponent {
  render() {
    return (
      <div className="component-emoji-results">
        {this.props.emojiData.map((emojiData, index) => (
          <EmojiResultRow
            key={index}
            symbol={emojiData.symbol}
            title={emojiData.title}
          />
        ))}
      </div>
    );
  }
}

[acdlite]

@gaearon @AlexanderKositsyn I know what the bug is. On my todo list :)

[acdlite]

Fixed by #12478

[gaearon]

@acdlite Wrong link?

[acdlite]

Oops, sorry. Meant #12254.