dangerouslySetInnerHTML not reconciling for P tags - likely due to nested P tags

[Surreal9]

I noticed when trying to use dangerouslySetInnerHTML for a P tag in a tutorial app I am building, it was having weird behaviour when the content was being changed. I am able to get the desired behaviour by using a div or span instead. I am using React 0.14.2.

This might be similar to #377

To view, check out this branch:
https://github.com/Surreal9/react-tutorial-journal-app/tree/bug/broken-edit-with-marked-and-p-tag

Steps to repro:

• Run the app, add a post
• Click the 'edit' icon next to the new post
• Edit the text, and hit 'Update Post'
• You should see the old post text still displayed, along with the newly updated text.

[waldreiter]

I followed your repro steps, but I could not see the bug. Wired. Maybe a bug was fixed in one of the npm packages? You could try deleting your node_modules folder to get a fresh install.

[Surreal9]

I just tried again from a different machine (also deleting node_modules and running npm install again), and I am still seeing the same behaviour. Here is a screenshot of what I'm describing, after adding a post with content 'Test post' and then editing it to say 'Test post - updated!'

I'm seeing the same thing in both Chrome and Firefox, on both a win 8 and win 10 machine. Are you sure you checked out the right branch (bug/broken-edit-with-marked-and-p-tag)? I've got it working on master by using a div instead of p tag.

[Surreal9]

I'm thinking this is a result of using marked for the inner html which is wrapping the content in P tags.. resulting in nested P tags, which according to http://stackoverflow.com/questions/12015804/nesting-p-wont-work-while-nesting-div-will isn't standards compliant. I will close this issue for now as I doubt React strives to handle non-compliant markup.

[waldreiter]

Your are right, I had used the wrong branch. Now I see the problem too.

My guess is that React can't help here. The browser alters the html to make it valid. React can't even warn properly since dangerouslySetInnerHTML is used.

[Surreal9]

Yes those are my thoughts as well. That's fine, thanks for looking into it!