[Possible Improvements] NODE_ENV === 'staging' and warning about minification

[le0pard]

Hello.

We using react for some our projects and found, what on staging servers it start generate warning about "It looks like you're using a minified copy of the development build of React. When deploying React apps to production, make sure to use the production build which skips development warnings and is faster".

We still need all possible warnings about propTypes or about controlled/uncontrolled components to debug all issues on environment, which as close as possible to production, but still is not production. In this case "staging" environment should be builded with minification to check app before delivering on production.

Proposal: remove this warning (

react/src/renderers/dom/ReactDOM.js

Lines 94 to 100 in 67f8524

	warning(
	(testFunc.name || testFunc.toString()).indexOf('testFn') !== -1,
	'It looks like you\'re using a minified copy of the development build ' +
	'of React. When deploying React apps to production, make sure to use ' +
	'the production build which skips development warnings and is faster. ' +
	'See https://fb.me/react-minification for more details.'
	);

) for NODE_ENV === 'staging' env, if this possible.

Thanks.

[jimfb]

In general, if you are minifying your code on staging to simulate a production environment, you should probably be running the production copy of React just in case there are any subtle differences in the code paths (there shouldn't be, if we did everything right, but you never know and it's that type of bug that can really bite you).

Anyway, closing as a duplicate of #6479

[gaearon]

Also, as I mention in #7512 (comment) regarding staging environment:

React 16 ships with separate entry points for production CommonJS bundles in react/cjs/react.production.min.js and react-dom/cjs/react-dom.production.min.js. You can alias react and react-dom to these bundles to force a production environment even if NODE_ENV says otherwise.

So there is a workaround.