Replaced "unstable_handleError" with "componentDidCatch" #10200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
changed the title
Ran new codemod to rename all identifiers. Searched-and-replaced strings occurrences.
bvaughn
force-pushed
the
error-boundaries
branch
from
b27d3a3 to
3a6a8ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React introduced the experimental "error boundaries" feature in version 15. Components define an
unstable_handleErrormethod to opt into this feature. Version 16 finalizes support for error boundaries, but with a new name-componentDidCatch.I ran a codemod to rename all identifiers in the React codebase. I also searched-and-replaced strings occurrences (eg test case names).
Relates to the "make error boundaries official" beta-blocker in #8854