Skip to content

Pass Jest useStderr flag when debugging #21741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jun 23, 2021

This prevents it from buffering and suppressing all console logs until a test has completed running (When debugging in Chrome). This is super annoying default behavior.

This prevents it from buffering adn suppressing all console logs until a test has completed running (When debugging in Chrome).
@bvaughn bvaughn requested a review from rickhanlonii June 23, 2021 20:55
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 23, 2021
@rickhanlonii
Copy link
Member

Nice!

@bvaughn
Copy link
Contributor Author

bvaughn commented Jun 23, 2021

Keep forgetting which flag does this and it's annoying as hell. Dunno why I didn't just commit this sooner. My bad.

@bvaughn bvaughn merged commit 8426bb6 into facebook:master Jun 23, 2021
@bvaughn bvaughn deleted the jest-debug-useStderr branch June 23, 2021 20:58
@sizebot
Copy link

sizebot commented Jun 23, 2021

Comparing: 355591a...c61b01d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.39 kB 127.39 kB = 40.83 kB 40.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.20 kB 130.20 kB = 41.74 kB 41.74 kB
facebook-www/ReactDOM-prod.classic.js = 405.80 kB 405.80 kB = 75.02 kB 75.02 kB
facebook-www/ReactDOM-prod.modern.js = 394.23 kB 394.23 kB = 73.25 kB 73.25 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.80 kB 405.80 kB = 75.02 kB 75.02 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c61b01d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants