[DevTools] Fix react-devtools-extension build error and react-devtools-inline's package.json
#22281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
jstejada
approved these changes
Sep 9, 2021
Contributor
jstejada
left a comment
jstejada
left a comment
There was a problem hiding this comment.
yay, thanks! could you add a test plan verifying that hook names still work for inline/extensions?
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
…ools-inline`'s `package.json` (facebook#22281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two bug fixes:
react-devtools-extensioncannot import fromreact-devtools-inline. It should only be importing shared code fromreact-devtools-shared. Fix this by importing thereact-devtools-sharedversion ofhookNames.hookNames.jsas an file to be included whenreact-devtools-inlineis installed as a dependency.Tested these bug fixes by building the extension and the test shell and verifying named hooks works as expected.