Skip to content

Update tutorial.md - adding the line for the jsx #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pvenkatakrishnan
Copy link

Adding /** @jsx React.DOM */ to the tutorial code snippets so that when copy pasted, the jsx transformer can convert it to javascript

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@@ -146,6 +148,7 @@ var CommentForm = React.createClass({
Next, update the `CommentBox` component to use its new friends:

```javascript{6-8}
/** @jsx React.DOM */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: all of these are usually the first thing in a block, indicating the filename. We might want to just get rid of them (cc @petehunt)

But also, when adding lines you need to update the highlights we have set (that the {6-8} in the opening of the code fence)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can update the highlights part, if you think this will still be useful to be added in.

@zpao
Copy link
Member

zpao commented Oct 6, 2014

I think we're getting rid of the need for the docblock in 0.12 so this may become unnecessary

@pvenkatakrishnan
Copy link
Author

ok thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants