Skip to content

Start monitoring uses of withContext, related to issue #2112 #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

jimfb
Copy link
Contributor

@jimfb jimfb commented Nov 7, 2014

  • Do a final read-through of the code.
  • Write more unit tests.

This is probably not ready to merge (though it shouldn't break anything). Would appreciate feedback.

@@ -44,6 +48,9 @@ var ReactContext = {
* @return {ReactComponent|array<ReactComponent>}
*/
withContext: function(newContext, scopedCallback) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: lets remove this line

@jimfb
Copy link
Contributor Author

jimfb commented Nov 12, 2014

Closing as duplicate of #2508.

@jimfb jimfb closed this Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants