Skip to content

Turn off enableAlwaysYieldScheduler #31856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Dec 19, 2024

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 2:18pm

@react-sizebot
Copy link

Comparing: a9bbe34...82a6d21

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 511.38 kB 511.38 kB = 91.38 kB 91.38 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 517.53 kB 517.53 kB = 92.34 kB 92.33 kB
facebook-www/ReactDOM-prod.classic.js = 593.09 kB 593.09 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 583.35 kB 583.35 kB = 102.90 kB 102.90 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/scheduler/cjs/Scheduler-dev.js +1.63% 11.91 kB 12.11 kB +1.76% 2.61 kB 2.66 kB
oss-experimental/scheduler/cjs/scheduler.development.js +1.62% 11.95 kB 12.14 kB +1.82% 2.64 kB 2.68 kB
oss-experimental/scheduler/cjs/scheduler.native.development.js +1.58% 12.14 kB 12.33 kB +1.68% 2.51 kB 2.55 kB
oss-experimental/scheduler/cjs/scheduler.production.js +1.33% 10.05 kB 10.18 kB +1.95% 2.46 kB 2.51 kB
oss-experimental/scheduler/cjs/scheduler.native.production.js +0.73% 10.79 kB 10.87 kB +0.82% 2.43 kB 2.45 kB

Generated by 🚫 dangerJS against ffa9a5a

@eps1lon eps1lon changed the title [scheduler] Turn off enableAlwaysYieldScheduler everywhere Turn off enableAlwaysYieldScheduler Dec 19, 2024
@eps1lon
Copy link
Collaborator Author

eps1lon commented Dec 19, 2024

Found a failing unit test with enableYieldingBeforePassive and the CSB still fails with this flag turned off so #31857 wins

@eps1lon eps1lon closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants