Skip to content

[Fizz] Add vt- prefix attributes to annotate <ViewTransition> in HTML #33206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 10 commits into from
May 15, 2025
+797 −60
Merged

[Fizz] Add vt- prefix attributes to annotate <ViewTransition> in HTML #33206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
42475d0
Remove isFallback
sebmarkbage May 14, 2025
59b87ef
Track fallback scope on the format context instead
sebmarkbage May 14, 2025
a3251a7
Pass FormatContext through to push
sebmarkbage May 14, 2025
7147b60
Update FormatContext when passing through a ViewTransition
sebmarkbage May 13, 2025
7cb9492
Track some tagScopes only shallowly until the next Instance or ViewTr…
sebmarkbage May 14, 2025
4757f60
Normalize the fields we need to emit
sebmarkbage May 14, 2025
d461179
Special case ViewTransition around Suspense
sebmarkbage May 14, 2025
ed2b02f
Push vt- attributes to the DOM node being rendered in a ViewTransitio…
sebmarkbage May 14, 2025
5707101
Don't treat the vt- attributes as a hydration mismatch
sebmarkbage May 14, 2025
88d3a04
Test
sebmarkbage May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/react-dom-bindings/src/client/ReactDOMComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ import {
enableScrollEndPolyfill,
enableSrcObject,
enableTrustedTypesIntegration,
enableViewTransition,
} from 'shared/ReactFeatureFlags';
import {
mediaEventTypes,
Expand Down Expand Up @@ -3217,6 +3218,18 @@ export function diffHydratedProperties(
break;
case 'selected':
break;
case 'vt-name':
case 'vt-update':
case 'vt-enter':
case 'vt-exit':
case 'vt-share':
if (enableViewTransition) {
// View Transition annotations are expected from the Server Runtime.
// However, if they're also specified on the client and don't match
// that's an error.
break;
}
// Fallthrough
default:
// Intentionally use the original name.
// See discussion in https://github.com/facebook/react/pull/10676.
Expand Down
Loading
Loading