-
Notifications
You must be signed in to change notification settings - Fork 50.2k
[compiler]: fix link compiler & 4 broken tests from path containing spaces #33409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
josephsavona
merged 19 commits into
facebook:main
from
wlemahieu:fix-compiler-path-spaces
Jun 9, 2025
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f39164c
add quotes around pwd path variable
wlemahieu e1b5d33
fix playground link-compiler script
wlemahieu 8e43092
normalize stack trace, fixing broken tests when pwd has spaces
wlemahieu 967509b
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu c469ac9
update test to reflect more accurate stack trace
wlemahieu 9d26eb3
Merge branch 'fix-compiler-path-spaces' of https://github.com/wlemahi…
wlemahieu e85ac58
drop superfluos comments
wlemahieu e891ef5
remove unnecessary change
wlemahieu bca0376
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 6f62bd9
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu ee7ce24
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 089e406
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 80baf40
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 960c927
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 362813c
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 7c22c5d
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 21a6fb5
revise regex and restore tests to original
wlemahieu 055ec70
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu 6c525d1
Merge branch 'main' into fix-compiler-path-spaces
wlemahieu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -528,7 +528,7 @@ describe('ReactTypeScriptClass', function () { | |
| ' in ProvideChildContextTypes (at **)', | ||
| 'StateBasedOnContext uses the legacy contextTypes API which will soon be removed. ' + | ||
| 'Use React.createContext() with static contextType instead. (https://react.dev/link/legacy-context)\n' + | ||
| ' in ProvideChildContextTypes.createElement (at **)', | ||
| ' in ProvideChildContextTypes.createElement [as render] (at **)', | ||
| ]); | ||
| }); | ||
| } | ||
|
|
@@ -721,7 +721,7 @@ describe('ReactTypeScriptClass', function () { | |
| ' in ProvideContext (at **)', | ||
| 'ReadContext uses the legacy contextTypes API which will soon be removed. ' + | ||
| 'Use React.createContext() with static contextType instead. (https://react.dev/link/legacy-context)\n' + | ||
| ' in ProvideContext.createElement (at **)', | ||
| ' in ProvideContext.createElement [as render] (at **)', | ||
|
||
| ]); | ||
| }); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated, let’s revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you for reviewing and for you spotting that. Fixed!