Skip to content

[Flight] Clarify Semantics for Awaiting Cached Data #33438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 6 commits into from
Jun 7, 2025
Merged

[Flight] Clarify Semantics for Awaiting Cached Data #33438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a27f74
Adjust cut off timing
sebmarkbage Jun 4, 2025
fdb2551
Change debugID to canEmitDebugInfo
sebmarkbage Jun 4, 2025
33df311
Clamp forwarded debug info to the start of the currently rendering co…
sebmarkbage Jun 4, 2025
d2f12e5
We need to read _debugInfo after a promise resolves since it's not gu…
sebmarkbage Jun 4, 2025
1e66d62
Ignore build directory too
sebmarkbage Jun 4, 2025
c19e900
Fix pendingChunks mismatch
sebmarkbage Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/react-client/src/__tests__/ReactFlight-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2826,46 +2826,46 @@ describe('ReactFlight', () => {
expect(getDebugInfo(thirdPartyChildren[0])).toEqual(
__DEV__
? [
{time: 14},
{time: 22}, // Clamped to the start
{
name: 'ThirdPartyComponent',
env: 'third-party',
key: null,
stack: ' in Object.<anonymous> (at **)',
props: {},
},
{time: 15},
{time: 22},
{time: 23}, // This last one is when the promise resolved into the first party.
]
: undefined,
);
expect(getDebugInfo(thirdPartyChildren[1])).toEqual(
__DEV__
? [
{time: 16},
{time: 22}, // Clamped to the start
{
name: 'ThirdPartyLazyComponent',
env: 'third-party',
key: null,
stack: ' in myLazy (at **)\n in lazyInitializer (at **)',
props: {},
},
{time: 17},
{time: 22},
]
: undefined,
);
expect(getDebugInfo(thirdPartyChildren[2])).toEqual(
__DEV__
? [
{time: 12},
{time: 22},
{
name: 'ThirdPartyFragmentComponent',
env: 'third-party',
key: '3',
stack: ' in Object.<anonymous> (at **)',
props: {},
},
{time: 13},
{time: 22},
]
: undefined,
);
Expand Down Expand Up @@ -2967,15 +2967,15 @@ describe('ReactFlight', () => {
expect(getDebugInfo(thirdPartyFragment.props.children)).toEqual(
__DEV__
? [
{time: 12},
{time: 19}, // Clamp to the start
{
name: 'ThirdPartyAsyncIterableComponent',
env: 'third-party',
key: null,
stack: ' in Object.<anonymous> (at **)',
props: {},
},
{time: 13},
{time: 19},
]
: undefined,
);
Expand Down
Loading
Loading