[Flight] Keep a separate ref count for debug chunks #33717
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: 9a645e1...cd60c89 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
unstubbable
left a comment
unstubbable
left a comment
There was a problem hiding this comment.
We also need to change this line, don't we?
The Postpone changes seem unrelated. Are you starting to clean up already?
| if (debug) { | ||
| request.pendingDebugChunks++; | ||
| } else { | ||
| request.pendingChunks++; // Extra chunk for the header. | ||
| } |
There was a problem hiding this comment.
Should we co-locate this with the if/else below?
There was a problem hiding this comment.
It might be misleading. It’s unfortunate the way it’s set up now that we add counts separately from pushing the chunks. We have to sometimes since they’re not always resolved immediately.
In this case this increment is not an exact pair with the push like it is in some other places. This is actually just one of two increments. So it might be misleading.
It’s more colocated with the header than the push.
|
I never implemented the postpone ones correctly in the first place for the debug channel so I just removed those branches. Treated as errors. Imminent deletion anyway. |
Fixed. |
4 participants
Same as #33716 but without the separate close signal.
We'll need the ref count for separate debug channel anyway but I'm not sure we'll need the separate close signal.