[Flight] Add Separate Outgoing Debug Channel #33754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "D" chunks are blocking the resolution of the actual value and we need to know that there might be something coming from the other channel so we know to block.
This is now just the same as have two sources. We don't need to distinguish which source the data is coming from. Each source has its own StreamState.
Instead of Uint8Array chunks. We could potentially always allow streams with variable chunk types even in prod and non-debug channels.
github-actions
bot
added
the
React Core Team
sebmarkbage
force-pushed
the
debugchannel
branch
from
0e0318e to
29287a8
Compare
Instead we wait for the debug channel to close before we close. That's always expected to stay open longer.
This event is fired if we're the ones closing it. Instead we let it close naturally when we finish after closing the debug channel.
sebmarkbage
force-pushed
the
debugchannel
branch
from
29287a8 to
c4a2c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us pass a writable on the server side and readable on the client side to send debug info through a separate channel so that it doesn't interfere with the main payload as much. The main payload refers to chunks defined in the debug info which means it's still blocked on it though. This ensures that the debug data has loaded by the time the value is rendered so that the next step can forward the data.
This will be a bit fragile to race conditions until #33665 lands. Another follow up needed is the ability to skip the debug channel on the receiving side. Right now it'll block forever if you don't provide one since we're blocking on the debug data.