Skip to content

[DevTools] Style clickable Owner components with angle brackets and bold #34096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 2 commits into from
Aug 4, 2025
Merged

[DevTools] Style clickable Owner components with angle brackets and bold #34096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e1987b
Style clickable Owner components with angle brackets and bold
sebmarkbage Aug 4, 2025
d1edfe4
Update tests
sebmarkbage Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-devtools-inline/__tests__/__e2e__/components.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ test.describe('Components', () => {

test('Should allow elements to be inspected', async () => {
// Select the first list item in DevTools.
await devToolsUtils.selectElement(page, 'ListItem', 'List\nApp');
await devToolsUtils.selectElement(page, 'ListItem', '<List>\n<App>');

// Prop names/values may not be editable based on the React version.
// If they're not editable, make sure they degrade gracefully
Expand Down Expand Up @@ -119,7 +119,7 @@ test.describe('Components', () => {
runOnlyForReactRange('>=16.8');

// Select the first list item in DevTools.
await devToolsUtils.selectElement(page, 'ListItem', 'List\nApp', true);
await devToolsUtils.selectElement(page, 'ListItem', '<List>\n<App>', true);

// Then read the inspected values.
const sourceText = await page.evaluate(() => {
Expand All @@ -142,7 +142,7 @@ test.describe('Components', () => {
runOnlyForReactRange('>=16.8');

// Select the first list item in DevTools.
await devToolsUtils.selectElement(page, 'ListItem', 'List\nApp');
await devToolsUtils.selectElement(page, 'ListItem', '<List>\n<App>');

// Then edit the label prop.
await page.evaluate(() => {
Expand Down Expand Up @@ -177,7 +177,7 @@ test.describe('Components', () => {
runOnlyForReactRange('>=16.8');

// Select the List component DevTools.
await devToolsUtils.selectElement(page, 'List', 'App');
await devToolsUtils.selectElement(page, 'List', '<App>');

// Then click to load and parse hook names.
await devToolsUtils.clickButton(page, 'LoadHookNamesButton');
Expand Down
1 change: 1 addition & 0 deletions packages/react-devtools-shared/src/devtools/views/Components/OwnerView.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
color: var(--color-component-name);
font-family: var(--font-family-monospace);
font-size: var(--font-size-monospace-normal);
font-weight: bold;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/devtools/views/Components/OwnerView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default function OwnerView({
<span
className={`${styles.Owner} ${isInStore ? '' : styles.NotInStore}`}
title={displayName}>
{displayName}
{'<' + displayName + '>'}
</span>

<ElementBadges
Expand Down
Loading