Skip to content

Use change event for Range inputs in IE #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jquense wants to merge 1 commit into from
Closed

Use change event for Range inputs in IE #4052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/renderers/dom/client/eventPlugins/ChangeEventPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,33 @@ var activeElementID = null;
var activeElementValue = null;
var activeElementValueProp = null;

var doesChangeEventBubble = false;
var documentMode = false;

if (ExecutionEnvironment.canUseDOM) {
documentMode = ('documentMode' in document) && document.documentMode;

// See `handleChange` comment below
doesChangeEventBubble = isEventSupported('change') && (
!documentMode || documentMode > 8
);
}

/**
* SECTION: handle `change` event
*/
function shouldUseChangeEvent(elem) {
var isIeRangeType = (
elem.type === 'range' && documentMode && documentMode <= 11
);

return (
elem.nodeName === 'SELECT' ||
(elem.nodeName === 'INPUT' && isIeRangeType) ||
(elem.nodeName === 'INPUT' && elem.type === 'file')
);
}

var doesChangeEventBubble = false;
if (ExecutionEnvironment.canUseDOM) {
// See `handleChange` comment below
doesChangeEventBubble = isEventSupported('change') && (
!('documentMode' in document) || document.documentMode > 8
);
}

function manualDispatchChangeEvent(nativeEvent) {
var event = SyntheticEvent.getPooled(
Expand Down Expand Up @@ -142,7 +152,7 @@ if (ExecutionEnvironment.canUseDOM) {
// IE9 claims to support the input event but fails to trigger it when
// deleting text, so we ignore its input events
isInputEventSupported = isEventSupported('input') && (
!('documentMode' in document) || document.documentMode > 9
!documentMode || documentMode > 9
);
}

Expand Down