Skip to content

[New Docs] Fix links for quick start and image size for implementation notes #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/contributing/design-principles.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ id: design-principles
title: Design Principles
layout: contributing
permalink: contributing/design-principles.html
prev: codebase-overview.html
prev: implementation-notes.html
---

We wrote this document so that you have a better idea of how we decide what React does and what React doesn't do, and what our development philosophy is like. While we are excited to see community contributions, we are not likely to choose a path that violates one or more of these principles.
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/implementation-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ The host internal instances need to store:

If you're struggling to imagine how an internal instance tree is structured in more complex applications, [React DevTools](https://github.com/facebook/react-devtools) can give you a close approximation, as it highlights host instances with grey, and composite instances with purple:

<img src="/react/img/docs/implementation-notes-tree.png" width="500" alt="React DevTools tree" />
<img src="/react/img/docs/implementation-notes-tree.png" width="500" style="max-width: 100%" alt="React DevTools tree" />

To complete this refactoring, we will introduce a function that mounts a complete tree into a container node, just like `ReactDOM.render()`. It returns a public instance, also like `ReactDOM.render()`:

Expand Down
1 change: 1 addition & 0 deletions docs/docs/composition-vs-inheritance.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ id: composition-vs-inheritance
title: Composition vs Inheritance
permalink: docs/composition-vs-inheritance.html
prev: lifting-state-up.html
next: thinking-in-react.html
---

React has a powerful composition model, and we recommend using composition instead of inheritance to reuse code between components.
Expand Down
2 changes: 2 additions & 0 deletions docs/docs/handling-events.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
id: handling-events
title: Handling Events
permalink: docs/handling-events.html
prev: state-and-lifecycle.html
next: lifting-state-up.html
---

Handling events with React elements is very similar to handling events on DOM elements. There are some syntactic differences:
Expand Down
1 change: 1 addition & 0 deletions docs/docs/state-and-lifecycle.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ id: state-and-lifecycle
title: State and Lifecycle
permalink: docs/state-and-lifecycle.html
prev: components-and-props.html
next: handling-events.html
---

Consider the ticking clock example from the [one of the previous sections](/react/docs/rendering-elements.html#updating-the-rendered-element).
Expand Down
1 change: 1 addition & 0 deletions docs/docs/thinking-in-react.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ id: thinking-in-react
title: Thinking in React
permalink: docs/thinking-in-react.html
redirect_from: 'blog/2013/11/05/thinking-in-react.html'
prev: composition-vs-inheritance.html
---

React is, in our opinion, the premier way to build big, fast Web apps with JavaScript. It has scaled very well for us at Facebook and Instagram.
Expand Down