Fix EventPluginRegistry Unit Tests
#91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumping the mock cache isn't dirying the modules, so we have to unit test a different way. If we can fix our unit test framework, we should revert this. Also, I added strict mode to `EventPluginRegistry.js`.
benjamn
added a commit
that referenced
this pull request
Jun 14, 2013
Fix `EventPluginRegistry` Unit Tests
andreypopp
pushed a commit
to andreypopp/jsxx
that referenced
this pull request
Feb 2, 2014
Dumping the mock cache isn't dirying the modules in the open source version, so we have to unit test a different way. If we can fix the unit test framework, we should revert this. Also, I added strict mode to `EventPluginRegistry.js`. See: facebook/react#91
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Fix spurious autoscroll
toptaldev92
pushed a commit
to toptaldev92/react_project
that referenced
this pull request
Jul 28, 2021
Dumping the mock cache isn't dirying the modules in the open source version, so we have to unit test a different way. If we can fix the unit test framework, we should revert this. Also, I added strict mode to `EventPluginRegistry.js`. See: facebook/react#91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping the mock cache isn't dirying the modules, so we have to unit test a different way. If we can fix our unit test framework, we should revert this.
Also, I added strict mode to
EventPluginRegistry.js.Test Plan
Ran
grunt testsuccessfully.