Fix: @catch on fragment root breaks usePaginationFragment and usePrefetchableForwardPaginationFragment#5281
Open
christiansany wants to merge 3 commits into
Conversation
…t hasNext When @catch is applied at the root of a fragment used by usePaginationFragment, hasNext is reported as false even when pageInfo.hasNextPage is true in the resolved data. The existing test (with @catch on the connection field) still passes, isolating the bug to root-level @catch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… usePrefetchableForwardPaginationFragment
@catch on fragment root breaks usePaginationFragment and usePrefetchableForwardPaginationFragment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
@catchis applied to the root of a fragment used withusePaginationFragment,hasNextalways returnedfalseeven when the response includedpageInfo.hasNextPage: true.@catchon a child field worked correctly — only the root-level case was broken.Root cause
When
@catchis on the fragment root, the compiler setsmetadata.catchTo: "RESULT"on the ReaderFragment. At read time,RelayReader._catchErrorswraps the entire fragment data in aResultenvelope:The pagination/refetch hook internals were reading fields directly off
fragmentDataand never unwrapping this envelope:getConnectionStatedidgetValueAtPath(fragmentData, ["friends"])→undefined→ returned{cursor: null, hasMore: false}→hasNext === false.useLoadMoreFunctionanduseRefetchableFragmentInternaldidfragmentData[identifierField]→undefined→ broken refetch identifier.Fix
Added a tiny helper
getFragmentInternalData(fragmentNode, fragmentData)that unwraps theResultenvelope whencatchTo === 'RESULT'(no-op otherwise). Applied it at every internal call site that reads fromfragmentData. The user-facingdatareturned fromusePaginationFragmentremains wrapped, matching the generatedResult<T, unknown>type.