Skip to content

feat: check and fix all_sol_json & new pareto_df parameters inputs#843

Merged
gufengzhou merged 5 commits intofacebookexperimental:mainfrom
laresbernardo:main
Oct 20, 2023
Merged

feat: check and fix all_sol_json & new pareto_df parameters inputs#843
gufengzhou merged 5 commits intofacebookexperimental:mainfrom
laresbernardo:main

Conversation

@laresbernardo
Copy link
Collaborator

@laresbernardo laresbernardo commented Oct 19, 2023 •
edited
Loading

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2023
@laresbernardo laresbernardo changed the title feat: check valid all_sol_json input feat: check and fix all_sol_json & new pareto_df parameters inputs Oct 19, 2023
gufengzhou
gufengzhou approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gufengzhou gufengzhou merged commit 353a5b3 into facebookexperimental:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gufengzhou gufengzhou gufengzhou approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laresbernardo @gufengzhou @facebook-github-bot