Skip to content

Robyn api update notebook and endpoint#912

Merged
yu-ya-tanaka merged 2 commits intomainfrom
robyn-api
Jan 31, 2024
Merged

Robyn api update notebook and endpoint#912
yu-ya-tanaka merged 2 commits intomainfrom
robyn-api

Conversation

@yu-ya-tanaka
Copy link
Contributor

@yu-ya-tanaka yu-ya-tanaka commented Jan 30, 2024

Project Robyn

Update notebook and endpoint

Fixes # (issue)

Type of change

  1. Notebook: updated index anchor wrong notebook links in robyn_python_notebook.ipynb #902
  2. Notebook: updated how to run and stop API
  3. Endpoint: fixed issue (InputCollect without setting context_vars and organic_vars) Robyn API via Python plumber didn't work when no organic_vars or factor_vars specifty #906

How Has This Been Tested?

  • Fork the repo and create your branch from master (latest dev version).
  • If you've changed docuemntation, run devtools::document(). Should update .Rd files.
  • Ensure all tests pass, run devtools::check(). Should have no notes, no warning, no errors.
  • Make sure your code lints.

@yu-ya-tanaka
Update Index in notebook & Update endpoint.R
2c97e80 
Notebook: Update index anchor. Now all anchor works correctly.
Endpoint: Update the function to convert InputCollect from JSON to R object. Now Robyn API can accept the InputCollect with no context vars and organic vars.
@yu-ya-tanaka
Update robyn_python_notebook.ipynb
81d10eb 
Update index anchor
Update how to start API on MAC.
@yu-ya-tanaka yu-ya-tanaka self-assigned this Jan 30, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 30, 2024
gufengzhou
gufengzhou approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yu-ya-tanaka yu-ya-tanaka merged commit 2ececb3 into main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gufengzhou gufengzhou gufengzhou approved these changes

Assignees

@yu-ya-tanaka yu-ya-tanaka

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yu-ya-tanaka @gufengzhou @facebook-github-bot