Skip to content

docs: clarify objective_weights order#929

Merged
laresbernardo merged 2 commits intomainfrom
blbranch
Feb 21, 2024
Merged

docs: clarify objective_weights order#929
laresbernardo merged 2 commits intomainfrom
blbranch

Conversation

@laresbernardo
Copy link
Collaborator

No description provided.

@laresbernardo laresbernardo added the documentation Improvements or additions to documentation label Feb 20, 2024
@laresbernardo laresbernardo self-assigned this Feb 20, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2024
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit confusing to have example of c(2,1) for only two objs, but there're 3 in total. We should explain when not calibrating, only RMSE and Rssd, then c(2,1) gives double weight to the first etc. Just more clarity please

@laresbernardo
Copy link
Collaborator Author

Alright, clarified.

Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@laresbernardo laresbernardo merged commit c9d2adf into main Feb 21, 2024
@laresbernardo laresbernardo deleted the blbranch branch February 21, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants