Skip to content

Fixed error when ts_validation is false.#965

Merged
gufengzhou merged 3 commits intomainfrom
robyn-api
May 7, 2024
Merged

Fixed error when ts_validation is false.#965
gufengzhou merged 3 commits intomainfrom
robyn-api

Conversation

@yu-ya-tanaka
Copy link
Contributor

Project Robyn

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)
Fixed error when ts_validation is false. When ts_validation is false, one-pager was not generated.

Type of change

  • fix: Added "@serializer json list(digits = 20, na = 'null')" for all post methods. This decorator prevents 1. rounding of a decimal, and 2. deletion of columns where the value are NA in the response of API.
  • fix: Updated the function to transform json of OutputCollect to R object.
  • update: Removed the warning message when converting the ggplot objects into hex, by adding suppressMessages().

How Has This Been Tested?

  • Tested on sample notebook and confirmed works correlty.

Added "@serializer json list(digits = 20, na = 'null')" for all post methods. This decorator prevents 1. rounding of a few, and 2. deletion of columns where the value are NA in the response of API.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2024
@yu-ya-tanaka yu-ya-tanaka requested review from ebyjose and gufengzhou May 4, 2024 16:57
@yu-ya-tanaka
Copy link
Contributor Author

This RP is to solve this issue. #946

Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gufengzhou gufengzhou merged commit 7acb3ce into main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants