Skip to content

Implement AnyLifetime for floats #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Implement AnyLifetime for floats #3

wants to merge 1 commit into from

Conversation

pierd
Copy link
Contributor

@pierd pierd commented Sep 16, 2021

... to simplify implementation of floats in starlark-rust.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2021
@facebook-github-bot
Copy link
Contributor

@ndmitchell has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ndmitchell
Copy link
Contributor

Thanks! This looks great. I'll land it shortly once it passes some internal tests (but given the diff, that's just a formality)

@pierd
Copy link
Contributor Author

pierd commented Sep 16, 2021

No worries, there's no rush. I've been using a local copy for development.

@facebook-github-bot
Copy link
Contributor

@ndmitchell merged this pull request in 5a566f8.

facebook-github-bot pushed a commit to facebookincubator/antlir that referenced this pull request Sep 16, 2021
@pierd @facebook-github-bot
Implement AnyLifetime for floats (#3)
1b73daf 
Summary:
... to simplify implementation of [floats in starlark-rust](facebook/starlark-rust#3).

Pull Request resolved: facebookincubator/gazebo#3

Reviewed By: blackm00n

Differential Revision: D30990124

Pulled By: ndmitchell

fbshipit-source-id: c365e39f44eb86ce173d2b04247a98d848f689e3
@ndmitchell
Copy link
Contributor

Thanks very much! I suggest I defer on making a release until you've got the Starlark pieces ready, in case you need to do any further Gazebo changes. But let me know once you think you are finished in Gazebo world.

@pierd pierd deleted the add-floats branch September 20, 2021 12:53
@pierd
Copy link
Contributor Author

pierd commented Sep 26, 2021

@ndmitchell It looks like I'm done in Gazebo world (almost done with float implementation).

@ndmitchell
Copy link
Contributor

Thanks! I'll make a release

facebook-github-bot pushed a commit that referenced this pull request Sep 27, 2021
@ndmitchell @facebook-github-bot
Prepare for a new Gazebo release
e17f92b 
Summary: As requested at #3 (comment)

Reviewed By: stepancheg

Differential Revision: D31216406

fbshipit-source-id: c229a094c9abf6f4e3954b3670568a15f4a9b2e7
@ndmitchell
Copy link
Contributor

Version 0.4.2 released, and I've bumped Starlark to require the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierd @facebook-github-bot @ndmitchell