feat: Add IPADDRESS support to Arbitrary aggregate function #16195
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The arbitrary() aggregate function was throwing NOT_IMPLEMENTED when used with IPADDRESS type. This was caught by the aggregation fuzzer. This change adds a check for isIPAddressType() for HUGEINT type in ArbitraryAggregate, allowing IPADDRESS values to be properly handled. Differential Revision: D92026533
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@pratikpugalia has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92026533. |
Contributor
|
Can you validate that this is implemented in Presto ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The arbitrary() aggregate function was throwing NOT_IMPLEMENTED when used
with IPADDRESS type. This was caught by the aggregation fuzzer.
This change adds a check for isIPAddressType() for HUGEINT type in
ArbitraryAggregate, allowing IPADDRESS values to be properly handled.
Differential Revision: D92026533