feat: Support unknown in coerceTypeBase #16207
Open
+154
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
👷 Deploy Preview for meta-velox processing.
|
marxhxxx
changed the title
marxhxxx
pushed a commit
to marxhxxx/velox
that referenced
this pull request
Feb 3, 2026
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to any target type with zero cost. Coercing UNKNOWN to UNKNOWN returns std::nullopt since no actual coercion is needed. Differential Revision: D92099013
marxhxxx
force-pushed
the
export-D92099013
branch
from
a2b9c49 to
a5593a4
Compare
marxhxxx
pushed a commit
to marxhxxx/velox
that referenced
this pull request
Feb 3, 2026
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to any target type with zero cost. Coercing UNKNOWN to UNKNOWN returns std::nullopt since no actual coercion is needed. Differential Revision: D92099013
marxhxxx
force-pushed
the
export-D92099013
branch
from
a5593a4 to
13be9e0
Compare
marxhxxx
pushed a commit
to marxhxxx/velox
that referenced
this pull request
Feb 4, 2026
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to any target type with zero cost. Coercing UNKNOWN to UNKNOWN returns std::nullopt since no actual coercion is needed. Differential Revision: D92099013
marxhxxx
pushed a commit
to marxhxxx/velox
that referenced
this pull request
Feb 4, 2026
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to any target type with zero cost. Coercing UNKNOWN to UNKNOWN returns std::nullopt since no actual coercion is needed. Differential Revision: D92099013
marxhxxx
force-pushed
the
export-D92099013
branch
from
13be9e0 to
f7910b3
Compare
marxhxxx
pushed a commit
to marxhxxx/velox
that referenced
this pull request
Feb 4, 2026
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to any target type with zero cost. Coercing UNKNOWN to UNKNOWN returns std::nullopt since no actual coercion is needed. Differential Revision: D92099013
marxhxxx
force-pushed
the
export-D92099013
branch
from
f7910b3 to
c26cf64
Compare
marxhxxx
pushed a commit
to marxhxxx/velox
that referenced
this pull request
Feb 4, 2026
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to any target type with zero cost. Differential Revision: D92099013
marxhxxx
force-pushed
the
export-D92099013
branch
from
c26cf64 to
1eed057
Compare
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to following types `TINYINT(), BOOLEAN(), SMALLINT(), INTEGER(), BIGINT(), REAL(), DOUBLE(), VARCHAR(), VARBINARY()`. Cost of the coercion is higher according to the list order. Differential Revision: D92099013
marxhxxx
force-pushed
the
export-D92099013
branch
from
1eed057 to
fa7516a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for UNKNOWN type coercion in coerceTypeBase. When the source type is UNKNOWN, it can be coerced to any target type with zero cost. Coercing UNKNOWN to UNKNOWN returns std::nullopt since no actual coercion is needed.
Differential Revision: D92099013