fix: Let spiller report file io stats #16209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
|
@tanjialiang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91977949. |
xiaoxmeng
approved these changes
Feb 3, 2026
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Feb 3, 2026
Summary: Pull Request resolved: facebookincubator#16209 file io stats are not currently reported from spilling. report such stats for more accuratlely tracking query level IO cost. Reviewed By: xiaoxmeng Differential Revision: D91977949
tanjialiang
force-pushed
the
export-D91977949
branch
from
31ff2c7 to
8492776
Compare
Summary: Pull Request resolved: facebookincubator#16209 file io stats are not currently reported from spilling. report such stats for more accuratlely tracking query level IO cost. Reviewed By: xiaoxmeng Differential Revision: D91977949
tanjialiang
force-pushed
the
export-D91977949
branch
from
8492776 to
ce12cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: file io stats are not currently reported from spilling. report such stats for more accuratlely tracking query level IO cost.
Reviewed By: xiaoxmeng
Differential Revision: D91977949